From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Richard Davies <richard@arachsys.com>,
Chris Webb <chris@arachsys.com>,
Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
Zhi Yong Wu <wuzhy@cn.ibm.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: [Qemu-devel] [PATCH 0/2] ide: convert pio code path to asynchronous I/O
Date: Wed, 28 Mar 2012 16:43:57 +0100 [thread overview]
Message-ID: <1332949439-6781-1-git-send-email-stefanha@linux.vnet.ibm.com> (raw)
IDE PIO mode is currently implemented using synchronous I/O functions. There's
no need to do this because the IDE interface is actually designed with polling
and interrupts in mind - we can do asynchronous I/O and let the guest know when
the operation has completed. The benefit of asynchronous I/O is that the guest
can continue executing code and is more responsive.
The second aim of this conversion is to avoid calling bdrv_read()/bdrv_write()
since they do not work with I/O throttling. This means guests should now boot
IDE drives successfully when I/O throttling is enabled.
Note that ATAPI is not converted yet and still uses bdrv_read() in two
locations. A future patch will have to convert ATAPI so CD-ROMs also do
asynchronous I/O.
I have tested both Windows 7 Home Premium and Red Hat Enterprise Linux 6.0
guests with these patches. In Windows, use the device manager to disable DMA
on the IDE channels. Under recent Linux kernels, use the libata.dma=0 kernel
parameter.
Chris and Richard: Please test this to confirm that it fixes the hang you
reported.
Stefan Hajnoczi (2):
ide: convert ide_sector_read() to asynchronous I/O
ide: convert ide_sector_write() to asynchronous I/O
hw/ide/core.c | 129 ++++++++++++++++++++++++++++++++++++----------------
hw/ide/internal.h | 2 +
2 files changed, 91 insertions(+), 40 deletions(-)
--
1.7.9.1
next reply other threads:[~2012-03-28 15:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-28 15:43 Stefan Hajnoczi [this message]
2012-03-28 15:43 ` [Qemu-devel] [PATCH 1/2] ide: convert ide_sector_read() to asynchronous I/O Stefan Hajnoczi
2012-03-29 6:42 ` Michael Tokarev
2012-03-29 8:29 ` Stefan Hajnoczi
2012-03-29 9:10 ` Paolo Bonzini
2012-03-29 6:46 ` Michael Tokarev
2012-03-29 7:00 ` Michael Tokarev
2012-03-28 15:43 ` [Qemu-devel] [PATCH 2/2] ide: convert ide_sector_write() " Stefan Hajnoczi
2012-03-28 15:51 ` [Qemu-devel] [PATCH 0/2] ide: convert pio code path " Chris Webb
2012-03-28 16:14 ` Paolo Bonzini
2012-03-29 2:15 ` Zhi Yong Wu
2012-03-29 11:30 ` Chris Webb
2012-03-29 13:36 ` Stefan Hajnoczi
2012-03-29 16:10 ` Chris Webb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1332949439-6781-1-git-send-email-stefanha@linux.vnet.ibm.com \
--to=stefanha@linux.vnet.ibm.com \
--cc=chris@arachsys.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard@arachsys.com \
--cc=wuzhy@cn.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).