From: Luiz Capitulino <lcapitulino@redhat.com>
To: qemu-devel@nongnu.org
Cc: mdroth@linux.vnet.ibm.com, aliguori@us.ibm.com,
kraxel@redhat.com, stefanha@linux.vnet.ibm.com,
armbru@redhat.com
Subject: [Qemu-devel] [RFC 00/13]: convert device_add to the qapi
Date: Thu, 29 Mar 2012 14:26:30 -0300 [thread overview]
Message-ID: <1333042003-15490-1-git-send-email-lcapitulino@redhat.com> (raw)
This is an RFC because it's not 100% finished yet and I'm not sure if some
of the changes are the way to go.
Here's a summary of the series its issues, more details can be found in
the patches:
o Patches 1 to 11 convert several qemu-option and qemu-config functions
from qerror_report() to error_set(). Note that not all users of those
functions are converted, so it might be needed to call qerror_report_err()
somewhere in the call stack to keep QError semantics.
Also, new versions of qemu_opt_set() and qemu_find_opts() that take an
Error parameter are introduced. This allows for incremental conversion
(vs. converting 100% of their users in one series)
o Patch 12 introduces support for allowing QAPI functions to accept a
variable list of arguments, which are unchecked and passed "as-is"
to the QAPI function. My implementation here is very hacky, please
check the patch for details
o Patch 13 does the QAPI conversion itself, but the HMP version of
device_add lacks its help text (ie. '?'). The problem here is that hmp.c
is really a QMP client and can only use what's provided by QMP. There are
two ways to solve this:
1. Anthony told me that he has this implemented in his tree, but
I couldn't find it. Anthony, can you point me to your
implementation?
2. Add a query-drivers command or similar to get a list of drivers,
so that the HMP command can use it to implement the help text
blockdev.c | 2 +-
hmp-commands.hx | 3 +-
hmp.c | 24 +++++++
hmp.h | 1 +
hw/qdev-monitor.c | 70 ++++++++++++++-----
hw/qdev.h | 2 +-
hw/usb/dev-storage.c | 2 +-
hw/watchdog.c | 2 +-
qapi-schema.json | 38 ++++++++++
qemu-char.c | 8 ++-
qemu-config.c | 43 +++++++++---
qemu-config.h | 3 +
qemu-option.c | 173 +++++++++++++++++++++++++++++++---------------
qemu-option.h | 6 +-
qemu-sockets.c | 8 +--
qerror.c | 4 ++
qerror.h | 3 +
qmp-commands.hx | 3 +-
scripts/qapi-commands.py | 31 ++++++++-
scripts/qapi.py | 2 +
vl.c | 25 ++++---
21 files changed, 342 insertions(+), 111 deletions(-)
next reply other threads:[~2012-03-29 17:26 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-29 17:26 Luiz Capitulino [this message]
2012-03-29 17:26 ` [Qemu-devel] [PATCH 01/13] qemu-option: qemu_opts_create(): use error_set() Luiz Capitulino
2012-03-29 17:26 ` [Qemu-devel] [PATCH 02/13] qemu-option: parse_option_number(): " Luiz Capitulino
2012-03-29 17:26 ` [Qemu-devel] [PATCH 03/13] qemu-option: parse_option_bool(): " Luiz Capitulino
2012-03-29 17:26 ` [Qemu-devel] [PATCH 04/13] qemu-option: parse_option_size(): " Luiz Capitulino
2012-03-29 17:26 ` [Qemu-devel] [PATCH 05/13] qemu-option: qemu_opt_parse(): " Luiz Capitulino
2012-03-29 17:26 ` [Qemu-devel] [PATCH 06/13] qemu-option: opt_set(): " Luiz Capitulino
2012-03-29 17:26 ` [Qemu-devel] [PATCH 07/13] qemu-option: opts_do_parse(): " Luiz Capitulino
2012-03-29 17:26 ` [Qemu-devel] [PATCH 08/13] qemu-option: introduce qemu_opt_set_err() Luiz Capitulino
2012-03-29 17:26 ` [Qemu-devel] [PATCH 09/13] qerror: introduce QERR_INVALID_OPTION_GROUP Luiz Capitulino
2012-03-29 17:26 ` [Qemu-devel] [PATCH 10/13] qemu-config: find_list(): use error_set() Luiz Capitulino
2012-03-29 17:26 ` [Qemu-devel] [PATCH 11/13] qemu-config: introduce qemu_find_opts_err() Luiz Capitulino
2012-03-29 17:26 ` [Qemu-devel] [PATCH 12/13] qapi: support for keyworded variable-length argument list Luiz Capitulino
2012-03-29 18:26 ` Anthony Liguori
2012-03-29 18:42 ` Luiz Capitulino
2012-03-29 18:53 ` Anthony Liguori
2012-03-29 19:28 ` Michael Roth
2012-03-29 20:01 ` Anthony Liguori
2012-03-29 22:39 ` Michael Roth
2012-03-29 22:56 ` Michael Roth
2012-03-30 7:49 ` Paolo Bonzini
2012-03-30 13:01 ` Luiz Capitulino
2012-03-29 20:03 ` Paolo Bonzini
2012-03-29 17:26 ` [Qemu-devel] [PATCH 13/13] qapi: convert device_add Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1333042003-15490-1-git-send-email-lcapitulino@redhat.com \
--to=lcapitulino@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=armbru@redhat.com \
--cc=kraxel@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).