From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39950) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SDLtk-000889-N8 for qemu-devel@nongnu.org; Thu, 29 Mar 2012 16:24:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SDLtj-0001s6-48 for qemu-devel@nongnu.org; Thu, 29 Mar 2012 16:24:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:7393) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SDLti-0001ro-S0 for qemu-devel@nongnu.org; Thu, 29 Mar 2012 16:24:43 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q2TKOfPP020007 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 29 Mar 2012 16:24:41 -0400 From: Alon Levy Date: Thu, 29 Mar 2012 22:24:38 +0200 Message-Id: <1333052678-18388-1-git-send-email-alevy@redhat.com> Subject: [Qemu-devel] [PATCH] qxl: set default values of vram*_size_mb to -1 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, kraxel@redhat.com The addition of those values caused a regression where not specifying any value for the vram bar size would result in a 4096 _byte_ surface area. This is ok for the windows driver but causes the X driver to be unusable. Also, it's a regression. This patch returns the default behavior of having a 64 megabyte vram BAR. Signed-off-by: Alon Levy --- hw/qxl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 47a162e..db2318e 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1959,8 +1959,8 @@ static Property qxl_properties[] = { DEFINE_PROP_UINT32("guestdebug", PCIQXLDevice, guestdebug, 0), DEFINE_PROP_UINT32("cmdlog", PCIQXLDevice, cmdlog, 0), DEFINE_PROP_UINT32("ram_size_mb", PCIQXLDevice, ram_size_mb, -1), - DEFINE_PROP_UINT32("vram_size_mb", PCIQXLDevice, vram32_size_mb, 0), - DEFINE_PROP_UINT32("vram64_size_mb", PCIQXLDevice, vram_size_mb, 0), + DEFINE_PROP_UINT32("vram_size_mb", PCIQXLDevice, vram32_size_mb, -1), + DEFINE_PROP_UINT32("vram64_size_mb", PCIQXLDevice, vram_size_mb, -1), DEFINE_PROP_END_OF_LIST(), }; -- 1.7.9.3