From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48746) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SDZpt-0001cR-HE for qemu-devel@nongnu.org; Fri, 30 Mar 2012 07:17:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SDZpr-0000Du-Gz for qemu-devel@nongnu.org; Fri, 30 Mar 2012 07:17:41 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:59874) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SDZpr-0000DJ-8N for qemu-devel@nongnu.org; Fri, 30 Mar 2012 07:17:39 -0400 Received: by mail-pb0-f45.google.com with SMTP id uo5so1822303pbc.4 for ; Fri, 30 Mar 2012 04:17:38 -0700 (PDT) Sender: Paolo Bonzini From: Paolo Bonzini Date: Fri, 30 Mar 2012 13:17:10 +0200 Message-Id: <1333106233-12472-2-git-send-email-pbonzini@redhat.com> In-Reply-To: <1333106233-12472-1-git-send-email-pbonzini@redhat.com> References: <1333106233-12472-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH 1/4] block: cancel jobs when a device is ready to go away List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, stefanha@linux.vnet.ibm.com We do not want jobs to keep a device busy for a possibly very long time, and management could become confused because they thought a device was not even there anymore. So, cancel long-running jobs as soon as their device is going to disappear. Signed-off-by: Paolo Bonzini --- blockdev.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/blockdev.c b/blockdev.c index 1a500b8..855a42d 100644 --- a/blockdev.c +++ b/blockdev.c @@ -64,6 +64,9 @@ void blockdev_mark_auto_del(BlockDriverState *bs) { DriveInfo *dinfo = drive_get_by_blockdev(bs); + if (bs->job) { + block_job_cancel(bs->job); + } if (dinfo) { dinfo->auto_del = 1; } -- 1.7.9.1