From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40034) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SDZyR-0007EA-3A for qemu-devel@nongnu.org; Fri, 30 Mar 2012 07:26:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SDZyL-0002eK-Nr for qemu-devel@nongnu.org; Fri, 30 Mar 2012 07:26:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:28877) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SDZyL-0002eA-Fz for qemu-devel@nongnu.org; Fri, 30 Mar 2012 07:26:25 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q2UBQNB4021425 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 30 Mar 2012 07:26:24 -0400 From: Gerd Hoffmann Date: Fri, 30 Mar 2012 13:26:21 +0200 Message-Id: <1333106781-12978-1-git-send-email-kraxel@redhat.com> Subject: [Qemu-devel] [PATCH] usb-ehci: drop assert() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Gerd Hoffmann Not sure what the purpose of the assert() was, in any case it is bogous. We can arrive there if transfer descriptors passed to us from the guest failed to pass sanity checks, i.e. it is guest-triggerable. We deal with that case by resetting the host controller. Everything is ok, no need to throw a core dump here. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index e12f098..23631a4 100644 --- a/hw/usb/hcd-ehci.c +++ b/hw/usb/hcd-ehci.c @@ -2009,7 +2009,6 @@ static void ehci_advance_state(EHCIState *ehci, fprintf(stderr, "processing error - resetting ehci HC\n"); ehci_reset(ehci); again = 0; - assert(0); } } while (again); -- 1.7.1