qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: lcapitulino@redhat.com
Subject: [Qemu-devel] [PATCH] tests: remove .SECONDARY special target
Date: Sat, 31 Mar 2012 12:50:21 +0200	[thread overview]
Message-ID: <1333191021-2189-1-git-send-email-pbonzini@redhat.com> (raw)

The special target should not be needed anymore, and caused (perhaps
due to a Make bug) a failure with "make -j2".  In any case, the
main makefile is a better place for such special targets rather
than an included makefile.

Reported-by: Luiz Capitulino <lcapitulino@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
	Anthony, this was taken from your patches, do you remember
        why it's needed?  I changed the rules to use the GNU Make
        "LIST: TARGET-PATTERN: SOURCE-PATTERN" syntax so there
        should be no implicit rules anymore and .SECONDARY should
        not be needed.

 tests/Makefile |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/tests/Makefile b/tests/Makefile
index 17f6ece..25a972a 100644
--- a/tests/Makefile
+++ b/tests/Makefile
@@ -74,8 +74,6 @@ check-help:
 	@echo "Default options are -k and (for make V=1) --verbose; they can be"
 	@echo "changed with variable GTESTER_OPTIONS."
 
-.SECONDARY:
-
 SPEED = quick
 GTESTER_OPTIONS = -k $(if $(V),--verbose,-q)
 
-- 
1.7.9.1

             reply	other threads:[~2012-03-31 10:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-31 10:50 Paolo Bonzini [this message]
2012-04-02  1:50 ` [Qemu-devel] [PATCH] tests: remove .SECONDARY special target Luiz Capitulino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1333191021-2189-1-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).