From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33791) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SDvt8-0004zf-P9 for qemu-devel@nongnu.org; Sat, 31 Mar 2012 06:50:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SDvt7-00077k-2h for qemu-devel@nongnu.org; Sat, 31 Mar 2012 06:50:30 -0400 Received: from mail-wi0-f175.google.com ([209.85.212.175]:42315) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SDvt6-00077X-MJ for qemu-devel@nongnu.org; Sat, 31 Mar 2012 06:50:28 -0400 Received: by wibhn6 with SMTP id hn6so1165255wib.10 for ; Sat, 31 Mar 2012 03:50:26 -0700 (PDT) Sender: Paolo Bonzini From: Paolo Bonzini Date: Sat, 31 Mar 2012 12:50:21 +0200 Message-Id: <1333191021-2189-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH] tests: remove .SECONDARY special target List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: lcapitulino@redhat.com The special target should not be needed anymore, and caused (perhaps due to a Make bug) a failure with "make -j2". In any case, the main makefile is a better place for such special targets rather than an included makefile. Reported-by: Luiz Capitulino Signed-off-by: Paolo Bonzini --- Anthony, this was taken from your patches, do you remember why it's needed? I changed the rules to use the GNU Make "LIST: TARGET-PATTERN: SOURCE-PATTERN" syntax so there should be no implicit rules anymore and .SECONDARY should not be needed. tests/Makefile | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/tests/Makefile b/tests/Makefile index 17f6ece..25a972a 100644 --- a/tests/Makefile +++ b/tests/Makefile @@ -74,8 +74,6 @@ check-help: @echo "Default options are -k and (for make V=1) --verbose; they can be" @echo "changed with variable GTESTER_OPTIONS." -.SECONDARY: - SPEED = quick GTESTER_OPTIONS = -k $(if $(V),--verbose,-q) -- 1.7.9.1