qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrange" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 9/9] Add note about some other options potentially worth enabling
Date: Mon,  2 Apr 2012 11:50:16 +0100	[thread overview]
Message-ID: <1333363816-1691-10-git-send-email-berrange@redhat.com> (raw)
In-Reply-To: <1333363816-1691-1-git-send-email-berrange@redhat.com>

From: "Daniel P. Berrange" <berrange@redhat.com>

There are a few other GCC warning options likely worth
enabling, but it is not practical with the level of warnings
generated. Add a note about them for anyone motiviated to
address it in the future

* configure: Add -Wclobbered, -Wmissing-field-initializers,
  -Woverride-init, -Wsign-compare, -Wunused-parameter,
  -Wunused-but-set-parameter, -Wpointer-arith, -Wmissing-noreturn,
  -Wjump-misses-init but leave disabled for now

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
---
 configure |   20 ++++++++++++++++++++
 1 files changed, 20 insertions(+), 0 deletions(-)

diff --git a/configure b/configure
index 175901f..2d62337 100755
--- a/configure
+++ b/configure
@@ -1199,6 +1199,26 @@ gcc_flags="$gcc_flags -Wformat-extra-args"
 gcc_flags="$gcc_flags -Wformat-zero-length"
 gcc_flags="$gcc_flags -Wformat-nonliteral"
 
+# Some other potentially worth enabling once issues are fixed
+# False positives in cpu-exec.c
+#gcc_flags="$gcc_flags -Wclobbered"
+# Many many violations
+#gcc_flags="$gcc_flags -Wmissing-field-initializers"
+# Quite a few (intentional?) overrides
+#gcc_flags="$gcc_flags -Woverride-init"
+# Many many violations
+#gcc_flags="$gcc_flags -Wsign-compare"
+# Many many violations
+#gcc_flags="$gcc_flags -Wunused-parameter"
+# Strange violations in mips helper
+#gcc_flags="$gcc_flags -Wunused-but-set-parameter"
+# Many many violations
+#gcc_flags="$gcc_flags -Wpointer-arith"
+# Many many violations
+#gcc_flags="$gcc_flags -Wmissing-noreturn"
+# Many many violations
+#gcc_flags="$gcc_flags -Wjump-misses-init"
+
 cat > $TMPC << EOF
 int main(void) { return 0; }
 EOF
-- 
1.7.7.6

  parent reply	other threads:[~2012-04-02 10:50 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-02 10:50 [Qemu-devel] Fix enablement of some compiler warning flags & add some more Daniel P. Berrange
2012-04-02 10:50 ` [Qemu-devel] [PATCH 1/9] Move all compiler warning/optimization flags to the same place Daniel P. Berrange
2012-04-02 16:19   ` Stefan Weil
2012-04-02 10:50 ` [Qemu-devel] [PATCH 2/9] Fix checking for compiler flag support Daniel P. Berrange
2012-04-02 12:29   ` Peter Maydell
2012-04-02 16:28   ` Stefan Weil
2012-04-02 10:50 ` [Qemu-devel] [PATCH 3/9] Print out progress when checking compiler flags Daniel P. Berrange
2012-04-02 13:56   ` Peter Maydell
2012-04-02 14:00     ` Daniel P. Berrange
2012-04-02 16:31   ` Stefan Weil
2012-04-02 10:50 ` [Qemu-devel] [PATCH 4/9] Remove 4 MB stack frame usage from sheepdog Daniel P. Berrange
2012-04-02 10:50 ` [Qemu-devel] [PATCH 5/9] Add in a large number of extra GCC warnings Daniel P. Berrange
2012-04-02 10:50 ` [Qemu-devel] [PATCH 6/9] Fix bit test to use & instead of && and enable -Wlogical-op warning Daniel P. Berrange
2012-04-02 12:27   ` Peter Maydell
2012-04-02 16:02     ` Maksim Kozlov
2012-04-02 10:50 ` [Qemu-devel] [PATCH 7/9] Add -Wmissing-format-attribute & fix problems it finds Daniel P. Berrange
2012-04-02 12:49   ` Andreas Färber
2012-04-02 10:50 ` [Qemu-devel] [PATCH 8/9] Add more format string warning flags Daniel P. Berrange
2012-04-02 12:13   ` Peter Maydell
2012-04-02 12:17     ` Daniel P. Berrange
2012-04-02 14:04       ` Peter Maydell
2012-04-02 14:22         ` Daniel P. Berrange
2012-04-02 14:32           ` Peter Maydell
2012-04-02 14:34             ` Daniel P. Berrange
2012-04-02 10:50 ` Daniel P. Berrange [this message]
2012-04-02 16:48   ` [Qemu-devel] [PATCH 9/9] Add note about some other options potentially worth enabling Stefan Weil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1333363816-1691-10-git-send-email-berrange@redhat.com \
    --to=berrange@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).