From: Anthony Liguori <aliguori@us.ibm.com>
To: qemu-devel@nongnu.org
Cc: Anthony Liguori <aliguori@us.ibm.com>
Subject: [Qemu-devel] [PATCH 2/2] serial: clear LSR.TEMT when populating the TSR
Date: Mon, 2 Apr 2012 09:39:39 -0500 [thread overview]
Message-ID: <1333377579-7513-3-git-send-email-aliguori@us.ibm.com> (raw)
In-Reply-To: <1333377579-7513-1-git-send-email-aliguori@us.ibm.com>
We never actually clear the TEMT (transmit sending register empty) flag when
populating the TSR. We set the flag, but since it's never cleared, setting it
is sort of pointless..
I found this with a unit test case.
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
---
hw/serial.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/hw/serial.c b/hw/serial.c
index b499bca..a421d1e 100644
--- a/hw/serial.c
+++ b/hw/serial.c
@@ -332,6 +332,7 @@ static void serial_xmit(void *opaque)
} else {
s->tsr = s->thr;
s->lsr |= UART_LSR_THRE;
+ s->lsr &= ~UART_LSR_TEMT;
}
}
--
1.7.5.4
next prev parent reply other threads:[~2012-04-02 14:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-02 14:39 [Qemu-devel] [PATCH 0/2] serial: some fixes for retry logic Anthony Liguori
2012-04-02 14:39 ` [Qemu-devel] [PATCH 1/2] serial: fix " Anthony Liguori
2012-04-02 16:18 ` Stefano Stabellini
2012-04-02 16:56 ` Anthony Liguori
2012-04-02 14:39 ` Anthony Liguori [this message]
2012-04-02 15:55 ` [Qemu-devel] [PATCH 0/2] serial: some fixes for " Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1333377579-7513-3-git-send-email-aliguori@us.ibm.com \
--to=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).