From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58928) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SEiQE-0004Z1-Dq for qemu-devel@nongnu.org; Mon, 02 Apr 2012 10:40:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SEiQ6-0003rc-Ma for qemu-devel@nongnu.org; Mon, 02 Apr 2012 10:39:53 -0400 Received: from cpe-70-123-132-139.austin.res.rr.com ([70.123.132.139]:34420 helo=localhost6.localdomain6) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SEiQ6-0003qp-Ff for qemu-devel@nongnu.org; Mon, 02 Apr 2012 10:39:46 -0400 From: Anthony Liguori Date: Mon, 2 Apr 2012 09:39:39 -0500 Message-Id: <1333377579-7513-3-git-send-email-aliguori@us.ibm.com> In-Reply-To: <1333377579-7513-1-git-send-email-aliguori@us.ibm.com> References: <1333377579-7513-1-git-send-email-aliguori@us.ibm.com> Subject: [Qemu-devel] [PATCH 2/2] serial: clear LSR.TEMT when populating the TSR List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Anthony Liguori We never actually clear the TEMT (transmit sending register empty) flag when populating the TSR. We set the flag, but since it's never cleared, setting it is sort of pointless.. I found this with a unit test case. Signed-off-by: Anthony Liguori --- hw/serial.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/serial.c b/hw/serial.c index b499bca..a421d1e 100644 --- a/hw/serial.c +++ b/hw/serial.c @@ -332,6 +332,7 @@ static void serial_xmit(void *opaque) } else { s->tsr = s->thr; s->lsr |= UART_LSR_THRE; + s->lsr &= ~UART_LSR_TEMT; } } -- 1.7.5.4