[Qemu-devel] [PATCH trivial] make: fix clean rule by removing build file in qom/

[Qemu-devel] [PATCH trivial] make: fix clean rule by removing build file in qom/

[Anthony PERARD]

Make clean does not clean the 'qom' directory, leaving *.o and *.d files. This
patch fixes this.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

---
 Makefile |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/Makefile b/Makefile
index 35c7a2a..a78f53d 100644
--- a/Makefile
+++ b/Makefile
@@ -217,6 +217,7 @@ clean:
 	rm -f *.o *.d *.a *.lo $(TOOLS) $(HELPERS-y) qemu-ga TAGS cscope.* *.pod *~ */*~
 	rm -Rf .libs
 	rm -f slirp/*.o slirp/*.d audio/*.o audio/*.d block/*.o block/*.d net/*.o net/*.d fsdev/*.o fsdev/*.d ui/*.o ui/*.d qapi/*.o qapi/*.d qga/*.o qga/*.d
+	rm -f qom/*.o qom/*.d
 	rm -f qemu-img-cmds.h
 	rm -f trace/*.o trace/*.d
 	rm -f trace.c trace.h trace.c-timestamp trace.h-timestamp
-- 
tg: (a3b6181..) fix/make-clean (depends on: master)

Re: [Qemu-devel] [Qemu-trivial] [PATCH trivial] make: fix clean rule by removing build file in qom/

[Stefan Hajnoczi]

On Mon, Apr 02, 2012 at 04:10:39PM +0100, Anthony PERARD wrote:
> Make clean does not clean the 'qom' directory, leaving *.o and *.d files. This
> patch fixes this.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> 
> ---
>  Makefile |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)

Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches

> tg: (a3b6181..) fix/make-clean (depends on: master)

What's this?  I'm curious.  First I thought it was a signature joke that
I didn't get but I guess it's for some kind of commit tracking system?

Stefan

Re: [Qemu-devel] [Qemu-trivial] [PATCH trivial] make: fix clean rule by removing build file in qom/

[Anthony PERARD]

On Tue, Apr 3, 2012 at 09:56, Stefan Hajnoczi <stefanha@gmail.com> wrote:
>
>> tg: (a3b6181..) fix/make-clean (depends on: master)
>
> What's this?  I'm curious.  First I thought it was a signature joke that
> I didn't get but I guess it's for some kind of commit tracking system?

No, it is not. To prepare a patch (or patch set), I use a tool called topgit.

http://repo.or.cz/w/topgit.git

It creates one git branch per patch, and you can add as many
dependence branch as you want. When you want to "rebase" a patch,
topgit will merge with the depends.

-- 
Anthony PERARD

Re: [Qemu-devel] [Qemu-trivial] [PATCH trivial] make: fix clean rule by removing build file in qom/

[Stefan Hajnoczi]

On Tue, Apr 03, 2012 at 11:06:45AM +0100, Anthony PERARD wrote:
> On Tue, Apr 3, 2012 at 09:56, Stefan Hajnoczi <stefanha@gmail.com> wrote:
> >
> >> tg: (a3b6181..) fix/make-clean (depends on: master)
> >
> > What's this?  I'm curious.  First I thought it was a signature joke that
> > I didn't get but I guess it's for some kind of commit tracking system?
> 
> No, it is not. To prepare a patch (or patch set), I use a tool called topgit.
> 
> http://repo.or.cz/w/topgit.git
> 
> It creates one git branch per patch, and you can add as many
> dependence branch as you want. When you want to "rebase" a patch,
> topgit will merge with the depends.

Thanks for sharing!

Stefan