From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48748) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SF1iu-0008Cg-UC for qemu-devel@nongnu.org; Tue, 03 Apr 2012 07:16:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SF1ip-0003A3-R0 for qemu-devel@nongnu.org; Tue, 03 Apr 2012 07:16:28 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:61671) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SF1ip-000393-Fi for qemu-devel@nongnu.org; Tue, 03 Apr 2012 07:16:23 -0400 Received: by mail-pb0-f45.google.com with SMTP id uo5so6178795pbc.4 for ; Tue, 03 Apr 2012 04:16:22 -0700 (PDT) Sender: Paolo Bonzini From: Paolo Bonzini Date: Tue, 3 Apr 2012 13:15:32 +0200 Message-Id: <1333451753-3550-5-git-send-email-pbonzini@redhat.com> In-Reply-To: <1333451753-3550-1-git-send-email-pbonzini@redhat.com> References: <1333451753-3550-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH 04/25] qom: make Object a type List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: aliguori@us.ibm.com, afaerber@suse.de Right now the base Object class has a special NULL type. Change this so that we will be able to add class_init and class_base_init callbacks. To do this, remove some special casing of ObjectClass that is not really necessary. Signed-off-by: Paolo Bonzini --- include/qemu/object.h | 2 +- qom/object.c | 59 +++++++++++++++++++++++++------------------------ 2 files changed, 31 insertions(+), 30 deletions(-) diff --git a/include/qemu/object.h b/include/qemu/object.h index ccaea7d..22f646d 100644 --- a/include/qemu/object.h +++ b/include/qemu/object.h @@ -33,7 +33,7 @@ typedef struct TypeInfo TypeInfo; typedef struct InterfaceClass InterfaceClass; typedef struct InterfaceInfo InterfaceInfo; -#define TYPE_OBJECT NULL +#define TYPE_OBJECT "object" /** * SECTION:object.h diff --git a/qom/object.c b/qom/object.c index 6ff1c19..585619d 100644 --- a/qom/object.c +++ b/qom/object.c @@ -210,7 +210,7 @@ static void type_class_interface_init(TypeImpl *ti, InterfaceImpl *iface) static void type_initialize(TypeImpl *ti) { - size_t class_size = sizeof(ObjectClass); + TypeImpl *parent; int i; if (ti->class) { @@ -221,30 +221,24 @@ static void type_initialize(TypeImpl *ti) ti->instance_size = type_object_get_size(ti); ti->class = g_malloc0(ti->class_size); - ti->class->type = ti; - - if (type_has_parent(ti)) { - TypeImpl *parent = type_get_parent(ti); + parent = type_get_parent(ti); + if (parent) { type_initialize(parent); - class_size = parent->class_size; g_assert(parent->class_size <= ti->class_size); + memcpy(ti->class, parent->class, parent->class_size); + } - memcpy((void *)ti->class + sizeof(ObjectClass), - (void *)parent->class + sizeof(ObjectClass), - parent->class_size - sizeof(ObjectClass)); + ti->class->type = ti; - while (parent) { - if (parent->class_base_init) { - parent->class_base_init(ti->class, ti->class_data); - } - parent = type_get_parent(parent); + while (parent) { + if (parent->class_base_init) { + parent->class_base_init(ti->class, ti->class_data); } + parent = type_get_parent(parent); } - memset((void *)ti->class + class_size, 0, ti->class_size - class_size); - for (i = 0; i < ti->num_interfaces; i++) { type_class_interface_init(ti, &ti->interfaces[i]); } @@ -467,19 +461,6 @@ Object *object_dynamic_cast(Object *obj, const char *typename) } -static void register_types(void) -{ - static TypeInfo interface_info = { - .name = TYPE_INTERFACE, - .instance_size = sizeof(Interface), - .abstract = true, - }; - - type_interface = type_register_static(&interface_info); -} - -type_init(register_types) - Object *object_dynamic_cast_assert(Object *obj, const char *typename) { Object *inst; @@ -1233,3 +1214,23 @@ void object_property_add_str(Object *obj, const char *name, property_release_str, prop, errp); } + +static void register_types(void) +{ + static TypeInfo interface_info = { + .name = TYPE_INTERFACE, + .instance_size = sizeof(Interface), + .abstract = true, + }; + + static TypeInfo object_info = { + .name = TYPE_OBJECT, + .instance_size = sizeof(Object), + .abstract = true, + }; + + type_interface = type_register_static(&interface_info); + type_register_static(&object_info); +} + +type_init(register_types) -- 1.7.9.3