qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: Paul Brook <paul@codesourcery.com>,
	Evgeny Voevodin <e.voevodin@samsung.com>,
	patches@linaro.org
Subject: [Qemu-devel] [PATCH 08/13] hw/exynos4210_gic.c: Convert to using sysbus GIC
Date: Wed,  4 Apr 2012 16:30:57 +0100	[thread overview]
Message-ID: <1333553462-12633-9-git-send-email-peter.maydell@linaro.org> (raw)
In-Reply-To: <1333553462-12633-1-git-send-email-peter.maydell@linaro.org>

Convert the Exynos GIC code to use the standalone sysbus
GIC device.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 hw/exynos4210_gic.c |   32 ++++++++++++++++++++++++--------
 1 files changed, 24 insertions(+), 8 deletions(-)

diff --git a/hw/exynos4210_gic.c b/hw/exynos4210_gic.c
index a05dab2..e1b215e 100644
--- a/hw/exynos4210_gic.c
+++ b/hw/exynos4210_gic.c
@@ -262,28 +262,44 @@ uint32_t exynos4210_get_irq(uint32_t grp, uint32_t bit)
 
 /********* GIC part *********/
 
-#define LEGACY_INCLUDED_GIC
-#include "arm_gic.c"
-
 typedef struct {
-    gic_state gic;
+    SysBusDevice busdev;
     MemoryRegion cpu_container;
     MemoryRegion dist_container;
     MemoryRegion cpu_alias[EXYNOS4210_NCPUS];
     MemoryRegion dist_alias[EXYNOS4210_NCPUS];
     uint32_t num_cpu;
+    DeviceState *gic;
 } Exynos4210GicState;
 
+static void exynos4210_gic_set_irq(void *opaque, int irq, int level)
+{
+    Exynos4210GicState *s = (Exynos4210GicState *)opaque;
+    qemu_set_irq(qdev_get_gpio_in(s->gic, irq), level);
+}
+
 static int exynos4210_gic_init(SysBusDevice *dev)
 {
-    Exynos4210GicState *s = FROM_SYSBUSGIC(Exynos4210GicState, dev);
+    Exynos4210GicState *s = FROM_SYSBUS(Exynos4210GicState, dev);
     uint32_t i;
     const char cpu_prefix[] = "exynos4210-gic-alias_cpu";
     const char dist_prefix[] = "exynos4210-gic-alias_dist";
     char cpu_alias_name[sizeof(cpu_prefix) + 3];
     char dist_alias_name[sizeof(cpu_prefix) + 3];
+    SysBusDevice *busdev;
+
+    s->gic = qdev_create(NULL, "arm_gic");
+    qdev_prop_set_uint32(s->gic, "num-cpu", s->num_cpu);
+    qdev_prop_set_uint32(s->gic, "num-irq", EXYNOS4210_GIC_NIRQ);
+    qdev_init_nofail(s->gic);
+    busdev = sysbus_from_qdev(s->gic);
+
+    /* Pass through outbound IRQ lines from the GIC */
+    sysbus_pass_irq(dev, busdev);
 
-    gic_init(&s->gic, s->num_cpu, EXYNOS4210_GIC_NIRQ);
+    /* Pass through inbound GPIO lines to the GIC */
+    qdev_init_gpio_in(&s->busdev.qdev, exynos4210_gic_set_irq,
+                      EXYNOS4210_GIC_NIRQ - 32);
 
     memory_region_init(&s->cpu_container, "exynos4210-cpu-container",
             EXYNOS4210_EXT_GIC_CPU_REGION_SIZE);
@@ -295,7 +311,7 @@ static int exynos4210_gic_init(SysBusDevice *dev)
         sprintf(cpu_alias_name, "%s%x", cpu_prefix, i);
         memory_region_init_alias(&s->cpu_alias[i],
                                  cpu_alias_name,
-                                 &s->gic.cpuiomem[0],
+                                 sysbus_mmio_get_region(busdev, 1),
                                  0,
                                  EXYNOS4210_GIC_CPU_REGION_SIZE);
         memory_region_add_subregion(&s->cpu_container,
@@ -305,7 +321,7 @@ static int exynos4210_gic_init(SysBusDevice *dev)
         sprintf(dist_alias_name, "%s%x", dist_prefix, i);
         memory_region_init_alias(&s->dist_alias[i],
                                  dist_alias_name,
-                                 &s->gic.iomem,
+                                 sysbus_mmio_get_region(busdev, 0),
                                  0,
                                  EXYNOS4210_GIC_DIST_REGION_SIZE);
         memory_region_add_subregion(&s->dist_container,
-- 
1.7.1

  parent reply	other threads:[~2012-04-04 15:31 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-04 15:30 [Qemu-devel] [PATCH 00/13] Convert ARM GIC to sysbus device Peter Maydell
2012-04-04 15:30 ` [Qemu-devel] [PATCH 01/13] hw/arm_gic: Move NCPU definition to arm_gic.c Peter Maydell
2012-04-05  4:29   ` Evgeny Voevodin
2012-04-04 15:30 ` [Qemu-devel] [PATCH 02/13] hw/arm_gic: Move gic_get_current_cpu into arm_gic.c Peter Maydell
2012-04-05  4:29   ` Evgeny Voevodin
2012-04-04 15:30 ` [Qemu-devel] [PATCH 03/13] hw/arm_gic.c: Expose PPI inputs as gpio inputs Peter Maydell
2012-04-04 15:30 ` [Qemu-devel] [PATCH 04/13] arm_gic: Make the GIC its own sysbus device Peter Maydell
2012-04-05  4:30   ` Evgeny Voevodin
2012-04-04 15:30 ` [Qemu-devel] [PATCH 05/13] hw/a15mpcore: switch to using sysbus GIC Peter Maydell
2012-04-04 15:30 ` [Qemu-devel] [PATCH 06/13] hw/a9mpcore.c: Switch " Peter Maydell
2012-04-04 15:30 ` [Qemu-devel] [PATCH 07/13] hw/realview_gic: switch to " Peter Maydell
2012-04-04 15:30 ` Peter Maydell [this message]
2012-04-05  4:30   ` [Qemu-devel] [PATCH 08/13] hw/exynos4210_gic.c: Convert to using " Evgeny Voevodin
2012-04-04 15:30 ` [Qemu-devel] [PATCH 09/13] hw/arm11mpcore: Convert to using sysbus GIC device Peter Maydell
2012-04-04 15:30 ` [Qemu-devel] [PATCH 10/13] hw/arm_gic: Make gic_reset a sysbus reset function Peter Maydell
2012-04-04 15:31 ` [Qemu-devel] [PATCH 11/13] hw/arm_gic.c: Use NVIC instead of LEGACY_INCLUDED_GIC define Peter Maydell
2012-04-04 15:31 ` [Qemu-devel] [PATCH 12/13] hw/arm_gic.c: gic_set_pending_private() is NVIC only Peter Maydell
2012-04-04 15:31 ` [Qemu-devel] [PATCH 13/13] hw/arm_gic.c: Remove stray hardcoded tab Peter Maydell
2012-04-05  4:31 ` [Qemu-devel] [PATCH 00/13] Convert ARM GIC to sysbus device Evgeny Voevodin
2012-04-05 12:23 ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1333553462-12633-9-git-send-email-peter.maydell@linaro.org \
    --to=peter.maydell@linaro.org \
    --cc=e.voevodin@samsung.com \
    --cc=patches@linaro.org \
    --cc=paul@codesourcery.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).