qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>
Subject: [Qemu-devel] [PATCH 13/14] configure: change meaning of --datadir to Autoconf convention
Date: Wed,  4 Apr 2012 15:32:24 -0300	[thread overview]
Message-ID: <1333564345-13011-14-git-send-email-ehabkost@redhat.com> (raw)
In-Reply-To: <1333564345-13011-1-git-send-email-ehabkost@redhat.com>

Autoconf uses --datadir for the /usr/share directory, not the
program-specific subdirectory inside /usr/share. This changes configure
to match autoconf behavior.

Note that this will break compatibility with existing build scripts.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 configure |    9 +++++----
 1 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/configure b/configure
index 37f455c..521d233 100755
--- a/configure
+++ b/configure
@@ -155,7 +155,7 @@ mingw32="no"
 EXESUF=""
 prefix="/usr/local"
 mandir="\${prefix}/share/man"
-qemu_datadir="\${prefix}/share/qemu"
+datadir="\${prefix}/share"
 qemu_docdir="\${prefix}/share/doc/qemu"
 bindir="\${prefix}/bin"
 libdir="\${prefix}/lib"
@@ -521,7 +521,7 @@ EOF
   fi
   prefix="c:/Program Files/Qemu"
   mandir="\${prefix}"
-  qemu_datadir="\${prefix}"
+  datadir="\${prefix}"
   qemu_docdir="\${prefix}"
   bindir="\${prefix}"
   sysconfdir="\${prefix}"
@@ -589,7 +589,7 @@ for opt do
   ;;
   --includedir=*) includedir="$optarg"
   ;;
-  --datadir=*) qemu_datadir="$optarg"
+  --datadir=*) datadir="$optarg"
   ;;
   --docdir=*) qemu_docdir="$optarg"
   ;;
@@ -1007,7 +1007,7 @@ echo "  --python=PYTHON          use specified python [$python]"
 echo "  --smbd=SMBD              use specified smbd [$smbd]"
 echo "  --static                 enable static build [$static]"
 echo "  --mandir=PATH            install man pages in PATH"
-echo "  --datadir=PATH           install firmware in PATH"
+echo "  --datadir=PATH           install firmware in PATH/qemu"
 echo "  --docdir=PATH            install documentation in PATH"
 echo "  --bindir=PATH            install binaries in PATH"
 echo "  --sysconfdir=PATH        install config in PATH/qemu"
@@ -2838,6 +2838,7 @@ if test "$mingw32" = "yes" ; then
 fi
 
 qemu_confdir=$sysconfdir$confsuffix
+qemu_datadir=$datadir$confsuffix
 
 tools=
 if test "$softmmu" = yes ; then
-- 
1.7.3.2

  parent reply	other threads:[~2012-04-04 18:32 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-04 18:32 [Qemu-devel] [PATCH v4 00/14] configure: --with-confsuffix option Eduardo Habkost
2012-04-04 18:32 ` [Qemu-devel] [PATCH 01/14] configure: rename $datadir to $qemu_datadir Eduardo Habkost
2012-04-04 18:32 ` [Qemu-devel] [PATCH 02/14] configure: rename $docdir to $qemu_docdir Eduardo Habkost
2012-04-04 18:32 ` [Qemu-devel] [PATCH 03/14] configure: rename $confdir to $qemu_confdir Eduardo Habkost
2012-04-04 18:32 ` [Qemu-devel] [PATCH 04/14] create_config: separate section for qemu_*dir variables (v2) Eduardo Habkost
2012-04-04 18:32 ` [Qemu-devel] [PATCH 05/14] config-host.mak: rename datadir to qemu_datadir Eduardo Habkost
2012-04-04 18:32 ` [Qemu-devel] [PATCH 06/14] config-host.mak: rename confdir to qemu_confdir Eduardo Habkost
2012-04-04 18:32 ` [Qemu-devel] [PATCH 07/14] Makefile: use $(qemu_confdir) instead of $(sysconfdir)/qemu Eduardo Habkost
2012-04-04 18:32 ` [Qemu-devel] [PATCH 08/14] config-host.mak: rename docdir to qemu_docdir Eduardo Habkost
2012-04-04 18:32 ` [Qemu-devel] [PATCH 09/14] config-host.mak: remove CONFIG_QEMU_SHAREDIR Eduardo Habkost
2012-04-04 18:32 ` [Qemu-devel] [PATCH 10/14] config-host.mak: reorder variables a bit Eduardo Habkost
2012-04-04 18:32 ` [Qemu-devel] [PATCH 11/14] create_config: remove *dir block Eduardo Habkost
2012-04-04 18:32 ` [Qemu-devel] [PATCH 12/14] create_config: simplify prefix=* block, remove CONFIG_QEMU_PREFIX Eduardo Habkost
2012-04-04 18:32 ` Eduardo Habkost [this message]
2012-04-04 18:32 ` [Qemu-devel] [PATCH 14/14] configure: add --with-confsuffix option Eduardo Habkost
  -- strict thread matches above, loose matches on Subject: below --
2012-03-30 17:32 [Qemu-devel] [PATCH 00/14] configure: " Eduardo Habkost
2012-03-30 17:33 ` [Qemu-devel] [PATCH 13/14] configure: change meaning of --datadir to Autoconf convention Eduardo Habkost
2012-04-04 15:25   ` Paolo Bonzini
2012-04-04 16:19     ` Eduardo Habkost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1333564345-13011-14-git-send-email-ehabkost@redhat.com \
    --to=ehabkost@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).