qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>
Subject: [Qemu-devel] [PATCH 05/14] config-host.mak: rename datadir to qemu_datadir
Date: Wed,  4 Apr 2012 15:32:16 -0300	[thread overview]
Message-ID: <1333564345-13011-6-git-send-email-ehabkost@redhat.com> (raw)
In-Reply-To: <1333564345-13011-1-git-send-email-ehabkost@redhat.com>

Autoconf concept of "datadir" is supposed to be "$prefix/share", not
"$prefix/share/PACKAGE", so using datadir for the Qemu-specific
directory is confusing.

The current C code that uses CONFIG_QEMU_DATADIR should be safe, as now
create_config generates the same #define name (CONFIG_QEMU_DATADIR) for
both "datadir" and "qemu_datadir" variables.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 Makefile        |    8 ++++----
 Makefile.target |    4 ++--
 configure       |    2 +-
 3 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/Makefile b/Makefile
index 35c7a2a..1c9abec 100644
--- a/Makefile
+++ b/Makefile
@@ -293,14 +293,14 @@ ifneq ($(HELPERS-y),)
 	$(INSTALL_PROG) $(STRIP_OPT) $(HELPERS-y) "$(DESTDIR)$(libexecdir)"
 endif
 ifneq ($(BLOBS),)
-	$(INSTALL_DIR) "$(DESTDIR)$(datadir)"
+	$(INSTALL_DIR) "$(DESTDIR)$(qemu_datadir)"
 	set -e; for x in $(BLOBS); do \
-		$(INSTALL_DATA) $(SRC_PATH)/pc-bios/$$x "$(DESTDIR)$(datadir)"; \
+		$(INSTALL_DATA) $(SRC_PATH)/pc-bios/$$x "$(DESTDIR)$(qemu_datadir)"; \
 	done
 endif
-	$(INSTALL_DIR) "$(DESTDIR)$(datadir)/keymaps"
+	$(INSTALL_DIR) "$(DESTDIR)$(qemu_datadir)/keymaps"
 	set -e; for x in $(KEYMAPS); do \
-		$(INSTALL_DATA) $(SRC_PATH)/pc-bios/keymaps/$$x "$(DESTDIR)$(datadir)/keymaps"; \
+		$(INSTALL_DATA) $(SRC_PATH)/pc-bios/keymaps/$$x "$(DESTDIR)$(qemu_datadir)/keymaps"; \
 	done
 	for d in $(TARGET_DIRS); do \
 	$(MAKE) -C $$d $@ || exit 1 ; \
diff --git a/Makefile.target b/Makefile.target
index cff15f0..6d7d95c 100644
--- a/Makefile.target
+++ b/Makefile.target
@@ -475,8 +475,8 @@ ifneq ($(STRIP),)
 endif
 endif
 ifdef CONFIG_TRACE_SYSTEMTAP
-	$(INSTALL_DIR) "$(DESTDIR)$(datadir)/../systemtap/tapset"
-	$(INSTALL_DATA) $(QEMU_PROG).stp "$(DESTDIR)$(datadir)/../systemtap/tapset"
+	$(INSTALL_DIR) "$(DESTDIR)$(qemu_datadir)/../systemtap/tapset"
+	$(INSTALL_DATA) $(QEMU_PROG).stp "$(DESTDIR)$(qemu_datadir)/../systemtap/tapset"
 endif
 
 # Include automatically generated dependency files
diff --git a/configure b/configure
index 95fa530..76144aa 100755
--- a/configure
+++ b/configure
@@ -2980,7 +2980,7 @@ echo "bindir=$bindir" >> $config_host_mak
 echo "libdir=$libdir" >> $config_host_mak
 echo "includedir=$includedir" >> $config_host_mak
 echo "mandir=$mandir" >> $config_host_mak
-echo "datadir=$qemu_datadir" >> $config_host_mak
+echo "qemu_datadir=$qemu_datadir" >> $config_host_mak
 echo "sysconfdir=$sysconfdir" >> $config_host_mak
 echo "docdir=$qemu_docdir" >> $config_host_mak
 echo "confdir=$qemu_confdir" >> $config_host_mak
-- 
1.7.3.2

  parent reply	other threads:[~2012-04-04 18:32 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-04 18:32 [Qemu-devel] [PATCH v4 00/14] configure: --with-confsuffix option Eduardo Habkost
2012-04-04 18:32 ` [Qemu-devel] [PATCH 01/14] configure: rename $datadir to $qemu_datadir Eduardo Habkost
2012-04-04 18:32 ` [Qemu-devel] [PATCH 02/14] configure: rename $docdir to $qemu_docdir Eduardo Habkost
2012-04-04 18:32 ` [Qemu-devel] [PATCH 03/14] configure: rename $confdir to $qemu_confdir Eduardo Habkost
2012-04-04 18:32 ` [Qemu-devel] [PATCH 04/14] create_config: separate section for qemu_*dir variables (v2) Eduardo Habkost
2012-04-04 18:32 ` Eduardo Habkost [this message]
2012-04-04 18:32 ` [Qemu-devel] [PATCH 06/14] config-host.mak: rename confdir to qemu_confdir Eduardo Habkost
2012-04-04 18:32 ` [Qemu-devel] [PATCH 07/14] Makefile: use $(qemu_confdir) instead of $(sysconfdir)/qemu Eduardo Habkost
2012-04-04 18:32 ` [Qemu-devel] [PATCH 08/14] config-host.mak: rename docdir to qemu_docdir Eduardo Habkost
2012-04-04 18:32 ` [Qemu-devel] [PATCH 09/14] config-host.mak: remove CONFIG_QEMU_SHAREDIR Eduardo Habkost
2012-04-04 18:32 ` [Qemu-devel] [PATCH 10/14] config-host.mak: reorder variables a bit Eduardo Habkost
2012-04-04 18:32 ` [Qemu-devel] [PATCH 11/14] create_config: remove *dir block Eduardo Habkost
2012-04-04 18:32 ` [Qemu-devel] [PATCH 12/14] create_config: simplify prefix=* block, remove CONFIG_QEMU_PREFIX Eduardo Habkost
2012-04-04 18:32 ` [Qemu-devel] [PATCH 13/14] configure: change meaning of --datadir to Autoconf convention Eduardo Habkost
2012-04-04 18:32 ` [Qemu-devel] [PATCH 14/14] configure: add --with-confsuffix option Eduardo Habkost
  -- strict thread matches above, loose matches on Subject: below --
2012-03-30 17:32 [Qemu-devel] [PATCH 00/14] configure: " Eduardo Habkost
2012-03-30 17:32 ` [Qemu-devel] [PATCH 05/14] config-host.mak: rename datadir to qemu_datadir Eduardo Habkost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1333564345-13011-6-git-send-email-ehabkost@redhat.com \
    --to=ehabkost@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).