From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38574) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SFovh-0001bZ-H7 for qemu-devel@nongnu.org; Thu, 05 Apr 2012 11:49:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SFovc-0006jN-06 for qemu-devel@nongnu.org; Thu, 05 Apr 2012 11:48:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:19339) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SFovb-0006ip-Ot for qemu-devel@nongnu.org; Thu, 05 Apr 2012 11:48:51 -0400 From: Kevin Wolf Date: Thu, 5 Apr 2012 17:51:40 +0200 Message-Id: <1333641144-13612-3-git-send-email-kwolf@redhat.com> In-Reply-To: <1333641144-13612-1-git-send-email-kwolf@redhat.com> References: <1333641144-13612-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH 02/46] tracetool: Forbid argument name 'next' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: anthony@codemonkey.ws Cc: kwolf@redhat.com, qemu-devel@nongnu.org It has happened more than once that patches that look perfectly sane and work with simpletrace broke systemtap because they use 'next' as an argument name for a tracing function. However, 'next' is a keyword for systemtap, so we shouldn't use it. Signed-off-by: Kevin Wolf --- scripts/tracetool | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/scripts/tracetool b/scripts/tracetool index 47389b6..7b1c142 100755 --- a/scripts/tracetool +++ b/scripts/tracetool @@ -81,6 +81,10 @@ get_args() args=${1#*\(} args=${args%%\)*} echo "$args" + + if (echo "$args" | grep "[ *]next\($\|[, ]\)" > /dev/null 2>&1); then + echo -e "\n#error 'next' is a bad argument name (clash with systemtap keyword)\n " + fi } # Get the argument name list of a trace event -- 1.7.6.5