From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50322) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SP8vU-0005sF-FY for qemu-devel@nongnu.org; Tue, 01 May 2012 04:59:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SP8vS-0007xW-K6 for qemu-devel@nongnu.org; Tue, 01 May 2012 04:59:16 -0400 From: Alexander Graf Date: Tue, 1 May 2012 10:58:59 +0200 Message-Id: <1335862740-17408-8-git-send-email-agraf@suse.de> In-Reply-To: <1335862740-17408-1-git-send-email-agraf@suse.de> References: <1335862740-17408-1-git-send-email-agraf@suse.de> Subject: [Qemu-devel] [PATCH 7/8] ppce500_spin: Replace assert by hw_error (fixes compiler warning) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel Developers Cc: blauwirbel@gmail.com, Stefan Weil , qemu-ppc@nongnu.org From: Stefan Weil The default case in function spin_read should never be reached, therefore the old code used assert(0) to abort QEMU. This does not work when QEMU is compiled with macro NDEBUG defined. In this case (and also when the compiler does not know that assert never returns), there is a compiler warning because of the missing return value. Using hw_error allows an improved error message and aborts always. Signed-off-by: Stefan Weil [agraf: use __func__] Signed-off-by: Alexander Graf --- hw/ppce500_spin.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/ppce500_spin.c b/hw/ppce500_spin.c index 95a2825..fddf219 100644 --- a/hw/ppce500_spin.c +++ b/hw/ppce500_spin.c @@ -179,7 +179,7 @@ static uint64_t spin_read(void *opaque, target_phys_addr_t addr, unsigned len) case 4: return ldl_p(spin_p); default: - assert(0); + hw_error("ppce500: unexpected %s with len = %u", __func__, len); } } -- 1.6.0.2