From: Kevin Wolf <kwolf@redhat.com>
To: anthony@codemonkey.ws
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 7/9] qcow2: fix the return value -ENOENT -> -EEXIST
Date: Wed, 2 May 2012 19:16:16 +0200 [thread overview]
Message-ID: <1335978978-4940-8-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1335978978-4940-1-git-send-email-kwolf@redhat.com>
From: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
Signed-off-by: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
Reviewed-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
block/qcow2-snapshot.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/block/qcow2-snapshot.c b/block/qcow2-snapshot.c
index 42f971b..4561a2a 100644
--- a/block/qcow2-snapshot.c
+++ b/block/qcow2-snapshot.c
@@ -331,7 +331,7 @@ int qcow2_snapshot_create(BlockDriverState *bs, QEMUSnapshotInfo *sn_info)
/* Check that the ID is unique */
if (find_snapshot_by_id(bs, sn_info->id_str) >= 0) {
- return -ENOENT;
+ return -EEXIST;
}
/* Populate sn with passed data */
--
1.7.6.5
next prev parent reply other threads:[~2012-05-02 17:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-02 17:16 [Qemu-devel] [PULL 0/9] Block patches (master and 1.1) Kevin Wolf
2012-05-02 17:16 ` [Qemu-devel] [PATCH 1/9] qemu-iotests: ignore fragmentation information for qed Kevin Wolf
2012-05-02 17:16 ` [Qemu-devel] [PATCH 2/9] block/qcow2: Add missing GCC_FMT_ATTR to function report_unsupported() Kevin Wolf
2012-05-02 17:16 ` [Qemu-devel] [PATCH 3/9] docs: fix one issue in qcow2 specs Kevin Wolf
2012-05-02 17:16 ` [Qemu-devel] [PATCH 4/9] qemu-iotests: Many parallel allocating I/O requests Kevin Wolf
2012-05-02 17:16 ` [Qemu-devel] [PATCH 5/9] qcow2: Remove unused parameter in do_alloc_cluster_offset Kevin Wolf
2012-05-02 17:16 ` [Qemu-devel] [PATCH 6/9] qcow2: Don't hold cache references across yield Kevin Wolf
2012-05-02 17:16 ` Kevin Wolf [this message]
2012-05-02 17:16 ` [Qemu-devel] [PATCH 8/9] rbd: add discard support Kevin Wolf
2012-05-02 17:16 ` [Qemu-devel] [PATCH 9/9] ATA: Allow WIN_SECURITY_FREEZE_LOCK as nop Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1335978978-4940-8-git-send-email-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).