From: MORITA Kazutaka <morita.kazutaka@gmail.com>
To: kwolf@redhat.com
Cc: morita.kazutaka@gmail.com, namei.unix@gmail.com, hch@lst.de,
qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH] sheepdog: switch to writethrough mode if cluster doesn't support flush
Date: Thu, 3 May 2012 05:26:07 +0900 [thread overview]
Message-ID: <1335990367-18749-1-git-send-email-morita.kazutaka@gmail.com> (raw)
This is necessary for qemu to work with the older version of Sheepdog
which doesn't support SD_OP_FLUSH_VDI.
Signed-off-by: MORITA Kazutaka <morita.kazutaka@gmail.com>
---
block/sheepdog.c | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/block/sheepdog.c b/block/sheepdog.c
index 0ed6b19..e01d371 100644
--- a/block/sheepdog.c
+++ b/block/sheepdog.c
@@ -1678,6 +1678,14 @@ static int coroutine_fn sd_co_flush_to_disk(BlockDriverState *bs)
return ret;
}
+ if (rsp->result == SD_RES_INVALID_PARMS) {
+ dprintf("disable write cache since the server doesn't support it\n");
+
+ s->cache_enabled = 0;
+ closesocket(s->flush_fd);
+ return 0;
+ }
+
if (rsp->result != SD_RES_SUCCESS) {
error_report("%s", sd_strerror(rsp->result));
return -EIO;
--
1.7.2.5
next reply other threads:[~2012-05-02 20:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-02 20:26 MORITA Kazutaka [this message]
2012-05-03 12:35 ` [Qemu-devel] [PATCH] sheepdog: switch to writethrough mode if cluster doesn't support flush Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1335990367-18749-1-git-send-email-morita.kazutaka@gmail.com \
--to=morita.kazutaka@gmail.com \
--cc=hch@lst.de \
--cc=kwolf@redhat.com \
--cc=namei.unix@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).