From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37078) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SPoNe-0004FV-Gw for qemu-devel@nongnu.org; Thu, 03 May 2012 01:15:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SPoNZ-0001PS-W7 for qemu-devel@nongnu.org; Thu, 03 May 2012 01:15:06 -0400 Received: from v220110690675601.yourvserver.net ([78.47.199.172]:58928) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SPoNZ-0001Ne-P1 for qemu-devel@nongnu.org; Thu, 03 May 2012 01:15:01 -0400 From: Stefan Weil Date: Thu, 3 May 2012 07:14:51 +0200 Message-Id: <1336022093-21467-5-git-send-email-sw@weilnetz.de> In-Reply-To: <1336022093-21467-1-git-send-email-sw@weilnetz.de> References: <1336022093-21467-1-git-send-email-sw@weilnetz.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH 4/6] hw/pc_sysfw: Fix memory leak List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Stefan Weil , Anthony Liguori Valgrind reported this memory leak which occured a few times. Test scenario: qemu-system-i386 (no arguments), only BIOS started, terminate with monitor command (quit). Signed-off-by: Stefan Weil Reviewed-by: Andreas F=C3=A4rber --- hw/pc_sysfw.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/hw/pc_sysfw.c b/hw/pc_sysfw.c index fafdf9b..f0d7c21 100644 --- a/hw/pc_sysfw.c +++ b/hw/pc_sysfw.c @@ -85,6 +85,9 @@ static void pc_fw_add_pflash_drv(void) filename =3D qemu_find_file(QEMU_FILE_TYPE_BIOS, bios_name); =20 opts =3D drive_add(IF_PFLASH, -1, filename, "readonly=3Don"); + + g_free(filename); + if (opts =3D=3D NULL) { return; } --=20 1.7.9