From: Stefan Weil <sw@weilnetz.de>
To: qemu-devel@nongnu.org
Cc: Stefan Weil <sw@weilnetz.de>, Anthony Liguori <aliguori@us.ibm.com>
Subject: [Qemu-devel] [PATCH 1.1] tci: Fix wrong macro name for debug code
Date: Thu, 3 May 2012 18:09:45 +0200 [thread overview]
Message-ID: <1336061385-5743-1-git-send-email-sw@weilnetz.de> (raw)
Code which is compiled with CONFIG_TCG_DEBUG (set by configure option
--enable-debug-tcg) should not disable the assert macro by
defining NDEBUG.
With the wrong macro name CONFIG_TCG_DEBUG, all assertions in tci.c
were completely useless because NDEBUG was always defined.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
tci.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
Please apply this fix before the release of QEMU 1.1.
Thanks,
Stefan Weil
diff --git a/tci.c b/tci.c
index 23a8368..e40c080 100644
--- a/tci.c
+++ b/tci.c
@@ -20,7 +20,7 @@
#include "config.h"
/* Defining NDEBUG disables assertions (which makes the code faster). */
-#if !defined(CONFIG_TCG_DEBUG) && !defined(NDEBUG)
+#if !defined(CONFIG_DEBUG_TCG) && !defined(NDEBUG)
# define NDEBUG
#endif
--
1.7.9
next reply other threads:[~2012-05-03 16:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-03 16:09 Stefan Weil [this message]
2012-05-03 16:15 ` [Qemu-devel] [PATCH 1.1] tci: Fix wrong macro name for debug code Peter Maydell
2012-05-08 17:28 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336061385-5743-1-git-send-email-sw@weilnetz.de \
--to=sw@weilnetz.de \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).