From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40121) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SQ0HZ-0006XG-U0 for qemu-devel@nongnu.org; Thu, 03 May 2012 13:57:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SQ0HX-00038W-St for qemu-devel@nongnu.org; Thu, 03 May 2012 13:57:37 -0400 Received: from e23smtp07.au.ibm.com ([202.81.31.140]:44330) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SQ0HX-00033y-BO for qemu-devel@nongnu.org; Thu, 03 May 2012 13:57:35 -0400 Received: from /spool/local by e23smtp07.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 3 May 2012 17:49:30 +1000 Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.235.138]) by d23relay04.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q43HnqX719005458 for ; Fri, 4 May 2012 03:49:55 +1000 Received: from d23av02.au.ibm.com (loopback [127.0.0.1]) by d23av02.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q43HuiY2008913 for ; Fri, 4 May 2012 03:56:44 +1000 From: Harsh Prateek Bora Date: Thu, 3 May 2012 23:26:34 +0530 Message-Id: <1336067796-5730-2-git-send-email-harsh@linux.vnet.ibm.com> In-Reply-To: <1336067796-5730-1-git-send-email-harsh@linux.vnet.ibm.com> References: <1336067796-5730-1-git-send-email-harsh@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH 1/3] monitor: remove unused do_info_trace List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Harsh Prateek Bora , aneesh.kumar@linux.vnet.ibm.com, stefanha@linux.vnet.ibm.com Going forward with simpletrace v2 variable size trace records, we cannot have a generic function to print trace event info and therefore this interface becomes invalid. As per Stefan Hajnoczi: "This command is only available from the human monitor. It's not very useful because it historically hasn't been able to pretty-print events or show them in the right order (we use a ringbuffer but it prints them out from index 0). Therefore, I don't think we're under any obligation to keep this command around. No one has complained about it's limitations - I think this is a sign that no one has used it. I'd be okay with a patch that removes it." Ref: http://lists.gnu.org/archive/html/qemu-devel/2012-01/msg01268.html Signed-off-by: Harsh Prateek Bora --- monitor.c | 16 ---------------- 1 files changed, 0 insertions(+), 16 deletions(-) diff --git a/monitor.c b/monitor.c index 8946a10..bebf864 100644 --- a/monitor.c +++ b/monitor.c @@ -812,13 +812,6 @@ static void do_info_cpu_stats(Monitor *mon) } #endif -#if defined(CONFIG_TRACE_SIMPLE) -static void do_info_trace(Monitor *mon) -{ - st_print_trace((FILE *)mon, &monitor_fprintf); -} -#endif - static void do_trace_print_events(Monitor *mon) { trace_print_events((FILE *)mon, &monitor_fprintf); @@ -2585,15 +2578,6 @@ static mon_cmd_t info_cmds[] = { .help = "show roms", .mhandler.info = do_info_roms, }, -#if defined(CONFIG_TRACE_SIMPLE) - { - .name = "trace", - .args_type = "", - .params = "", - .help = "show current contents of trace buffer", - .mhandler.info = do_info_trace, - }, -#endif { .name = "trace-events", .args_type = "", -- 1.7.1.1