From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:56890) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hE8kh-0002Pv-Ap for qemu-devel@nongnu.org; Wed, 10 Apr 2019 04:38:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hE8kf-0007LO-C9 for qemu-devel@nongnu.org; Wed, 10 Apr 2019 04:38:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35486) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hE8kd-0007Jj-F5 for qemu-devel@nongnu.org; Wed, 10 Apr 2019 04:38:35 -0400 Date: Wed, 10 Apr 2019 04:38:33 -0400 (EDT) From: Pankaj Gupta Message-ID: <1336073020.20708683.1554885513376.JavaMail.zimbra@redhat.com> In-Reply-To: <20190410082804.GG1426@quack2.suse.cz> References: <20190410040826.24371-1-pagupta@redhat.com> <20190410040826.24371-4-pagupta@redhat.com> <20190410082804.GG1426@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 3/6] libnvdimm: add dax_dev sync flag List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kara Cc: linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-acpi@vger.kernel.org, qemu-devel@nongnu.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, dan j williams , zwisler@kernel.org, vishal l verma , dave jiang , mst@redhat.com, jasowang@redhat.com, willy@infradead.org, rjw@rjwysocki.net, hch@infradead.org, lenb@kernel.org, tytso@mit.edu, adilger kernel , darrick wong , lcapitulino@redhat.com, kwolf@redhat.com, imammedo@redhat.com, jmoyer@redhat.com, nilal@redhat.com, riel@surriel.com, stefanha@redhat.com, aarcange@redhat.com, david@redhat.com, david@fromorbit.com, cohuck@redhat.com, xiaoguangrong eric , pbonzini@redhat.com, kilobyte@angband.pl, yuval shaia > > On Wed 10-04-19 09:38:23, Pankaj Gupta wrote: > > @@ -64,6 +65,10 @@ static inline bool dax_write_cache_enabled(struct > > dax_device *dax_dev) > > { > > return false; > > } > > +static inline bool dax_synchronous(struct dax_device *dax_dev) > > +{ > > + return true; > > +} > > Is there a need to define dax_synchronous() for !CONFIG_DAX? Because that > property of dax device is pretty much undefined and I don't see anything > needing to call it for !CONFIG_DAX... You are right. Will remove this. Thanks for the review. Best regards, Pankaj > > Honza > -- > Jan Kara > SUSE Labs, CR > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDC02C10F11 for ; Wed, 10 Apr 2019 08:39:48 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9BF3C2075B for ; Wed, 10 Apr 2019 08:39:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9BF3C2075B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:55817 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hE8ln-0002t6-Pw for qemu-devel@archiver.kernel.org; Wed, 10 Apr 2019 04:39:47 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56890) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hE8kh-0002Pv-Ap for qemu-devel@nongnu.org; Wed, 10 Apr 2019 04:38:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hE8kf-0007LO-C9 for qemu-devel@nongnu.org; Wed, 10 Apr 2019 04:38:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35486) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hE8kd-0007Jj-F5 for qemu-devel@nongnu.org; Wed, 10 Apr 2019 04:38:35 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 25C9F3088A7E; Wed, 10 Apr 2019 08:38:34 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 043A45D962; Wed, 10 Apr 2019 08:38:34 +0000 (UTC) Received: from zmail21.collab.prod.int.phx2.redhat.com (zmail21.collab.prod.int.phx2.redhat.com [10.5.83.24]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id B08A91803385; Wed, 10 Apr 2019 08:38:33 +0000 (UTC) Date: Wed, 10 Apr 2019 04:38:33 -0400 (EDT) From: Pankaj Gupta To: Jan Kara Message-ID: <1336073020.20708683.1554885513376.JavaMail.zimbra@redhat.com> In-Reply-To: <20190410082804.GG1426@quack2.suse.cz> References: <20190410040826.24371-1-pagupta@redhat.com> <20190410040826.24371-4-pagupta@redhat.com> <20190410082804.GG1426@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.65.16.19, 10.4.195.22] Thread-Topic: libnvdimm: add dax_dev sync flag Thread-Index: 3uZjW5jhUzBiRAKeiJEV9NRdm5X/hQ== X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Wed, 10 Apr 2019 08:38:34 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH v5 3/6] libnvdimm: add dax_dev sync flag X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: cohuck@redhat.com, kvm@vger.kernel.org, mst@redhat.com, jasowang@redhat.com, david@fromorbit.com, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, adilger kernel , zwisler@kernel.org, aarcange@redhat.com, dave jiang , linux-nvdimm@lists.01.org, vishal l verma , david@redhat.com, willy@infradead.org, hch@infradead.org, linux-acpi@vger.kernel.org, jmoyer@redhat.com, linux-ext4@vger.kernel.org, lenb@kernel.org, kilobyte@angband.pl, riel@surriel.com, yuval shaia , stefanha@redhat.com, pbonzini@redhat.com, dan j williams , lcapitulino@redhat.com, kwolf@redhat.com, nilal@redhat.com, tytso@mit.edu, xiaoguangrong eric , darrick wong , rjw@rjwysocki.net, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, imammedo@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Message-ID: <20190410083833.fQh5nlasSRW0zN0H7dZFE-s9ApMpCwkkuCfKV0aU7xE@z> > > On Wed 10-04-19 09:38:23, Pankaj Gupta wrote: > > @@ -64,6 +65,10 @@ static inline bool dax_write_cache_enabled(struct > > dax_device *dax_dev) > > { > > return false; > > } > > +static inline bool dax_synchronous(struct dax_device *dax_dev) > > +{ > > + return true; > > +} > > Is there a need to define dax_synchronous() for !CONFIG_DAX? Because that > property of dax device is pretty much undefined and I don't see anything > needing to call it for !CONFIG_DAX... You are right. Will remove this. Thanks for the review. Best regards, Pankaj > > Honza > -- > Jan Kara > SUSE Labs, CR >