From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49335) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SQEA1-000834-RY for qemu-devel@nongnu.org; Fri, 04 May 2012 04:46:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SQEA0-0007Qk-0W for qemu-devel@nongnu.org; Fri, 04 May 2012 04:46:45 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:40984) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SQE9z-0007G0-MN for qemu-devel@nongnu.org; Fri, 04 May 2012 04:46:43 -0400 Received: by mail-pb0-f45.google.com with SMTP id ro12so4505829pbb.4 for ; Fri, 04 May 2012 01:46:42 -0700 (PDT) Sender: Paolo Bonzini From: Paolo Bonzini Date: Fri, 4 May 2012 10:45:51 +0200 Message-Id: <1336121154-26517-12-git-send-email-pbonzini@redhat.com> In-Reply-To: <1336121154-26517-1-git-send-email-pbonzini@redhat.com> References: <1336121154-26517-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH 11/14] scsi: do not require a minimum allocation length for REQUEST SENSE List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org The requirements on the REQUEST SENSE buffer size are not in my copy of SPC (SPC-4 r27) and not observed by LIO. Rip them out. Signed-off-by: Paolo Bonzini --- hw/scsi-bus.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c index 4090b9f..925c3ae 100644 --- a/hw/scsi-bus.c +++ b/hw/scsi-bus.c @@ -427,9 +427,6 @@ static int32_t scsi_target_send_command(SCSIRequest *req, uint8_t *buf) } break; case REQUEST_SENSE: - if (req->cmd.xfer < 4) { - goto illegal_request; - } r->len = scsi_device_get_sense(r->req.dev, r->buf, MIN(req->cmd.xfer, sizeof r->buf), (req->cmd.buf[1] & 1) == 0); @@ -538,8 +535,8 @@ SCSIRequest *scsi_req_new(SCSIDevice *d, uint32_t tag, uint32_t lun, req = scsi_req_alloc(&reqops_unit_attention, d, tag, lun, hba_private); } else if (lun != d->lun || - buf[0] == REPORT_LUNS || - (buf[0] == REQUEST_SENSE && (d->sense_len || cmd.xfer < 4))) { + buf[0] == REPORT_LUNS || + (buf[0] == REQUEST_SENSE && d->sense_len)) { req = scsi_req_alloc(&reqops_target_command, d, tag, lun, hba_private); } else { -- 1.7.9.3