From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52722) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SRJf7-0004ew-Pe for qemu-devel@nongnu.org; Mon, 07 May 2012 04:51:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SRJf3-0003qC-0T for qemu-devel@nongnu.org; Mon, 07 May 2012 04:51:21 -0400 Received: from e33.co.us.ibm.com ([32.97.110.151]:33624) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SRJf2-0003pr-Pr for qemu-devel@nongnu.org; Mon, 07 May 2012 04:51:16 -0400 Received: from /spool/local by e33.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 7 May 2012 02:51:15 -0600 Received: from d01relay07.pok.ibm.com (d01relay07.pok.ibm.com [9.56.227.147]) by d01dlp03.pok.ibm.com (Postfix) with ESMTP id 59EF9C90057 for ; Mon, 7 May 2012 04:51:09 -0400 (EDT) Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by d01relay07.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q478pBE420447412 for ; Mon, 7 May 2012 04:51:11 -0400 Received: from d01av01.pok.ibm.com (loopback [127.0.0.1]) by d01av01.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q47EM3bd022454 for ; Mon, 7 May 2012 10:22:03 -0400 From: zwu.kernel@gmail.com Date: Mon, 7 May 2012 16:51:03 +0800 Message-Id: <1336380663-29742-1-git-send-email-zwu.kernel@gmail.com> Subject: [Qemu-devel] [PATCH v2 2/2] qcow2: lock on prealloc List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, Zhi Yong Wu , stefanha@linux.vnet.ibm.com From: Zhi Yong Wu preallocate() will be locked. Signed-off-by: Zhi Yong Wu --- block/qcow2.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 8c60a6f..ee4678f 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -1192,7 +1192,10 @@ static int qcow2_create2(const char *filename, int64_t total_size, /* And if we're supposed to preallocate metadata, do that now */ if (prealloc) { + BDRVQcowState *s = bs->opaque; + qemu_co_mutex_lock(&s->lock); ret = preallocate(bs); + qemu_co_mutex_unlock(&s->lock); if (ret < 0) { goto out; } -- 1.7.6