From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52811) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SRo9h-00008a-Ru for qemu-devel@nongnu.org; Tue, 08 May 2012 13:25:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SRo9Z-0007Ye-Qc for qemu-devel@nongnu.org; Tue, 08 May 2012 13:24:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:30798) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SRo9Z-0007YW-IV for qemu-devel@nongnu.org; Tue, 08 May 2012 13:24:49 -0400 From: Luiz Capitulino Date: Tue, 8 May 2012 14:24:46 -0300 Message-Id: <1336497889-23730-4-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1336497889-23730-1-git-send-email-lcapitulino@redhat.com> References: <1336497889-23730-1-git-send-email-lcapitulino@redhat.com> Subject: [Qemu-devel] [PATCH 3/6] qemu-ga: guest-shutdown: don't emit a success response List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: pbonzini@redhat.com, mdroth@linux.vnet.ibm.com, mprivozn@redhat.com Today, qemu-ga may not be able to emit a success response when guest-shutdown completes. This happens because the VM may vanish before qemu-ga is able to emit a response. This semantic is a bit confusing, as it's not clear for clients if they should wait for a response or how they should check for success. This commit solves that problem by changing guest-shutdown to never emit a success response and suggests in the documentation what clients could do to check for success. Signed-off-by: Luiz Capitulino --- qapi-schema-guest.json | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/qapi-schema-guest.json b/qapi-schema-guest.json index d7a073e..82f901a 100644 --- a/qapi-schema-guest.json +++ b/qapi-schema-guest.json @@ -131,11 +131,15 @@ # # @mode: #optional "halt", "powerdown" (default), or "reboot" # -# Returns: Nothing on success +# This command does NOT return a response on success. Success condition +# is indicated by the VM exiting with a zero exit status or, when +# running with --no-shutdown, by issuing the query-status QMP command +# to confirm the VM status is "shutdown". # # Since: 0.15.0 ## -{ 'command': 'guest-shutdown', 'data': { '*mode': 'str' } } +{ 'command': 'guest-shutdown', 'data': { '*mode': 'str' }, + 'success-response': 'no' } ## # @guest-file-open: -- 1.7.9.2.384.g4a92a