From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52922) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SRoA9-0001Zx-Im for qemu-devel@nongnu.org; Tue, 08 May 2012 13:25:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SRoA4-0007ol-Qi for qemu-devel@nongnu.org; Tue, 08 May 2012 13:25:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:12881) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SRoA4-0007oO-I5 for qemu-devel@nongnu.org; Tue, 08 May 2012 13:25:20 -0400 From: Luiz Capitulino Date: Tue, 8 May 2012 14:24:47 -0300 Message-Id: <1336497889-23730-5-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1336497889-23730-1-git-send-email-lcapitulino@redhat.com> References: <1336497889-23730-1-git-send-email-lcapitulino@redhat.com> Subject: [Qemu-devel] [PATCH 4/6] qemu-ga: guest-suspend-disk: don't emit a success response List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: pbonzini@redhat.com, mdroth@linux.vnet.ibm.com, mprivozn@redhat.com Today, qemu-ga may not be able to emit a success response when guest-suspend-disk completes. This happens because the VM may vanish before qemu-ga is able to emit a response. This semantic is a bit confusing, as it's not clear for clients if they should wait for a response or how they should check for success. This commit solves that problem by changing guest-suspend-disk to never emit a success response and suggests in the documentation what clients could do to check for success. Signed-off-by: Luiz Capitulino --- qapi-schema-guest.json | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/qapi-schema-guest.json b/qapi-schema-guest.json index 82f901a..64db215 100644 --- a/qapi-schema-guest.json +++ b/qapi-schema-guest.json @@ -363,17 +363,21 @@ # For the best results it's strongly recommended to have the pm-utils # package installed in the guest. # -# Returns: nothing on success +# This command does NOT return a response on success. There is a high chance +# the command succeeded if the VM exits with a zero exit status or, when +# running with --no-shutdown, by issuing the query-status QMP command to +# to confirm the VM status is "shutdown". However, the VM could also exit +# (or set its status to "shutdown") due to other reasons. +# +# The following errors may be returned: # If suspend to disk is not supported, Unsupported # -# Notes: o This is an asynchronous request. There's no guarantee a response -# will be sent -# o It's strongly recommended to issue the guest-sync command before -# sending commands when the guest resumes +# Notes: It's strongly recommended to issue the guest-sync command before +# sending commands when the guest resumes # # Since: 1.1 ## -{ 'command': 'guest-suspend-disk' } +{ 'command': 'guest-suspend-disk', 'success-response': 'no' } ## # @guest-suspend-ram -- 1.7.9.2.384.g4a92a