From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45031) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SRulN-0001Wj-Ce for qemu-devel@nongnu.org; Tue, 08 May 2012 20:28:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SRulL-0000oP-D0 for qemu-devel@nongnu.org; Tue, 08 May 2012 20:28:16 -0400 From: =?UTF-8?q?Andreas=20F=C3=A4rber?= Date: Wed, 9 May 2012 02:28:07 +0200 Message-Id: <1336523290-6899-2-git-send-email-afaerber@suse.de> In-Reply-To: <1336523290-6899-1-git-send-email-afaerber@suse.de> References: <1336523290-6899-1-git-send-email-afaerber@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH v2 for-1.1 1/4] tcg/ppc: Do not overwrite lower address word on Darwin and AIX List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Andreas=20F=C3=A4rber?= , qemu-ppc@nongnu.org, agraf@suse.de From: Andreas F=C3=A4rber For targets where TARGET_LONG_BITS !=3D 32, i.e. 64-bit guests, addr_reg is moved to r4. For hosts without TCG_TARGET_CALL_ALIGN_ARGS either data_reg2 or data_reg or a masked version thereof would overwrite r4. Place it in r5 instead, matching TCG_TARGET_CALL_ALIGN_ARGS hosts. This fixes immediate crashes of 64-bit guests observed on Darwin/ppc but not on Darwin/ppc64. Signed-off-by: Andreas F=C3=A4rber --- tcg/ppc/tcg-target.c | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/tcg/ppc/tcg-target.c b/tcg/ppc/tcg-target.c index dc40716..4b85c89 100644 --- a/tcg/ppc/tcg-target.c +++ b/tcg/ppc/tcg-target.c @@ -816,11 +816,7 @@ static void tcg_out_qemu_st (TCGContext *s, const TC= GArg *args, int opc) #else tcg_out_mov (s, TCG_TYPE_I32, 3, addr_reg2); tcg_out_mov (s, TCG_TYPE_I32, 4, addr_reg); -#ifdef TCG_TARGET_CALL_ALIGN_ARGS ir =3D 5; -#else - ir =3D 4; -#endif #endif =20 switch (opc) { --=20 1.7.7