From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56715) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SSW5w-0001Qx-GN for qemu-devel@nongnu.org; Thu, 10 May 2012 12:20:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SSW5m-0007u9-MD for qemu-devel@nongnu.org; Thu, 10 May 2012 12:20:00 -0400 Received: from mx.meyering.net ([88.168.87.75]:42155) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SSW5m-0007tm-Fi for qemu-devel@nongnu.org; Thu, 10 May 2012 12:19:50 -0400 From: Jim Meyering Date: Thu, 10 May 2012 18:19:47 +0200 Message-Id: <1336666788-30233-2-git-send-email-jim@meyering.net> In-Reply-To: <1336666788-30233-1-git-send-email-jim@meyering.net> References: <1336666788-30233-1-git-send-email-jim@meyering.net> Subject: [Qemu-devel] [PATCH 1/2] kvm/apic: correct short memset List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Jim Meyering , Jan Kiszka , Anthony Liguori , =?UTF-8?q?Andreas=20F=C3=A4rber?= , Avi Kivity From: Jim Meyering kvm_put_apic_state's attempt to clear *kapic before setting its bits cleared sizeof(void*) bytes (no more than 8) rather than the intended 1024 (KVM_APIC_REG_SIZE) bytes. Spotted by coverity. Signed-off-by: Jim Meyering --- hw/kvm/apic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/kvm/apic.c b/hw/kvm/apic.c index ffe7a52..a0ab503 100644 --- a/hw/kvm/apic.c +++ b/hw/kvm/apic.c @@ -29,7 +29,7 @@ void kvm_put_apic_state(DeviceState *d, struct kvm_lapic_state *kapic) APICCommonState *s = DO_UPCAST(APICCommonState, busdev.qdev, d); int i; - memset(kapic, 0, sizeof(kapic)); + memset(kapic, 0, sizeof(*kapic)); kvm_apic_set_reg(kapic, 0x2, s->id << 24); kvm_apic_set_reg(kapic, 0x8, s->tpr); kvm_apic_set_reg(kapic, 0xd, s->log_dest << 24); -- 1.7.10.1.487.ga3935e6