From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37399) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SSqwz-00029d-Bv for qemu-devel@nongnu.org; Fri, 11 May 2012 10:36:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SSqwt-0001uT-8C for qemu-devel@nongnu.org; Fri, 11 May 2012 10:36:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:26343) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SSqws-0001tN-VW for qemu-devel@nongnu.org; Fri, 11 May 2012 10:36:03 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q4BEa09m022668 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 11 May 2012 10:36:00 -0400 From: Kevin Wolf Date: Fri, 11 May 2012 15:43:49 +0200 Message-Id: <1336743829-15951-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH] qcow2: Don't ignore failure to clear autoclear flags List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com Signed-off-by: Kevin Wolf --- block/qcow2.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 3bae2d8..655799c 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -300,7 +300,10 @@ static int qcow2_open(BlockDriverState *bs, int flags) if (!bs->read_only && s->autoclear_features != 0) { s->autoclear_features = 0; - qcow2_update_header(bs); + ret = qcow2_update_header(bs); + if (ret < 0) { + goto fail; + } } /* Check support for various header values */ -- 1.7.6.5