From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44037) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1STKp9-0008ST-Gh for qemu-devel@nongnu.org; Sat, 12 May 2012 18:30:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1STKp7-0007Pj-PK for qemu-devel@nongnu.org; Sat, 12 May 2012 18:30:03 -0400 Received: from gate.crashing.org ([63.228.1.57]:32781) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1STKp7-0007O5-Go for qemu-devel@nongnu.org; Sat, 12 May 2012 18:30:01 -0400 Message-ID: <1336861783.31450.4.camel@pasglop> From: Benjamin Herrenschmidt Date: Sun, 13 May 2012 08:29:43 +1000 In-Reply-To: <4FAE11D1.9090103@ozlabs.ru> References: <4FAE11D1.9090103@ozlabs.ru> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Subject: Re: [Qemu-devel] [RFC PATCH] kernel vfio: enabled and supported on power List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy Cc: qemu-devel@nongnu.org, Alex Williamson , Alex Graf , kvm@vger.kernel.org, David Gibson On Sat, 2012-05-12 at 17:31 +1000, Alexey Kardashevskiy wrote: > And drivers/vfio/vfio_iommu_x86.c works perfect for POWER except a DMA > window setup > which I dropped for now and simply use quite popular configuration on > power (1Gb DMA window starting > from 0x0). > > As for me, it is too complicated. We do not need either > - platform specific IOMMU chardev or > - IOMMU API at all > > What do I miss? I think we want to get rid of the "generic" iommu API and make it x86 specific at this stage. A lot of what the guest is going to do with the iommu is really platform specific at this stage, especially when we start adding the EEH functionality, which is PE-based, or when we want to implement the guest calls for creating dynamic windows. Cheers, Ben.