qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
	"Anthony Liguori" <aliguori@us.ibm.com>,
	"Andreas Färber" <afaerber@suse.de>,
	anthony@codemonkey.ws
Subject: [Qemu-devel] [PATCH 5/7] qdev: Fix adding of ptr properties
Date: Sun, 13 May 2012 20:27:43 +0200	[thread overview]
Message-ID: <1336933665-3867-6-git-send-email-afaerber@suse.de> (raw)
In-Reply-To: <1336933665-3867-1-git-send-email-afaerber@suse.de>

From: Anthony Liguori <aliguori@us.ibm.com>

ptr properties have neither a get/set or a print/parse which means that when
they're added they aren't treated as static or legacy properties.

Just assume properties like this are legacy properties and treat them as such.

Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 hw/qdev.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/hw/qdev.c b/hw/qdev.c
index 0bcde20..6a8f6bd 100644
--- a/hw/qdev.c
+++ b/hw/qdev.c
@@ -576,9 +576,12 @@ void qdev_property_add_legacy(DeviceState *dev, Property *prop,
 {
     gchar *name, *type;
 
-    if (!prop->info->print && !prop->info->parse) {
+    /* Register pointer properties as legacy properties */
+    if (!prop->info->print && !prop->info->parse &&
+        (prop->info->set || prop->info->get)) {
         return;
     }
+
     name = g_strdup_printf("legacy-%s", prop->name);
     type = g_strdup_printf("legacy<%s>",
                            prop->info->legacy_name ?: prop->info->name);
-- 
1.7.7

  parent reply	other threads:[~2012-05-13 18:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-13 18:27 [Qemu-devel] [PULL for-1.1-rc2] Fixes from QOM-related series Andreas Färber
2012-05-13 18:27 ` [Qemu-devel] [PATCH 1/7] target-mips: Remove commented-out function declaration Andreas Färber
2012-05-13 18:27 ` [Qemu-devel] [PATCH 2/7] qom: Documentation addition for object_class_by_name() Andreas Färber
2012-05-13 18:27 ` [Qemu-devel] [PATCH 3/7] target-i386: Defer MCE init Andreas Färber
2012-05-13 18:27 ` [Qemu-devel] [PATCH 4/7] qdev: Use object_property_print() in info qtree Andreas Färber
2012-05-13 18:27 ` Andreas Färber [this message]
2012-05-13 18:27 ` [Qemu-devel] [PATCH 6/7] pc: Add back PCI.rombar compat property Andreas Färber
2012-05-13 18:27 ` [Qemu-devel] [PATCH 7/7] mips_fulong2e: Don't register "cpu" VMState twice Andreas Färber
2012-05-14 12:56 ` [Qemu-devel] [PULL for-1.1-rc2] Fixes from QOM-related series Luiz Capitulino
2012-05-14 20:08 ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1336933665-3867-6-git-send-email-afaerber@suse.de \
    --to=afaerber@suse.de \
    --cc=aliguori@us.ibm.com \
    --cc=anthony@codemonkey.ws \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).