From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36896) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1STdWq-00081V-SI for qemu-devel@nongnu.org; Sun, 13 May 2012 14:28:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1STdWo-0007YW-NP for qemu-devel@nongnu.org; Sun, 13 May 2012 14:28:24 -0400 Received: from cantor2.suse.de ([195.135.220.15]:38467 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1STdWo-0007YF-H6 for qemu-devel@nongnu.org; Sun, 13 May 2012 14:28:22 -0400 From: =?UTF-8?q?Andreas=20F=C3=A4rber?= Date: Sun, 13 May 2012 20:27:43 +0200 Message-Id: <1336933665-3867-6-git-send-email-afaerber@suse.de> In-Reply-To: <1336933665-3867-1-git-send-email-afaerber@suse.de> References: <1336933665-3867-1-git-send-email-afaerber@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH 5/7] qdev: Fix adding of ptr properties List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Anthony Liguori , =?UTF-8?q?Andreas=20F=C3=A4rber?= , anthony@codemonkey.ws From: Anthony Liguori ptr properties have neither a get/set or a print/parse which means that w= hen they're added they aren't treated as static or legacy properties. Just assume properties like this are legacy properties and treat them as = such. Signed-off-by: Anthony Liguori Signed-off-by: Paolo Bonzini Signed-off-by: Andreas F=C3=A4rber --- hw/qdev.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index 0bcde20..6a8f6bd 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -576,9 +576,12 @@ void qdev_property_add_legacy(DeviceState *dev, Prop= erty *prop, { gchar *name, *type; =20 - if (!prop->info->print && !prop->info->parse) { + /* Register pointer properties as legacy properties */ + if (!prop->info->print && !prop->info->parse && + (prop->info->set || prop->info->get)) { return; } + name =3D g_strdup_printf("legacy-%s", prop->name); type =3D g_strdup_printf("legacy<%s>", prop->info->legacy_name ?: prop->info->name); --=20 1.7.7