From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41922) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1STxRy-0005ht-VP for qemu-devel@nongnu.org; Mon, 14 May 2012 11:44:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1STxRs-0000F6-5q for qemu-devel@nongnu.org; Mon, 14 May 2012 11:44:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:16760) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1STxRr-0000Ep-T4 for qemu-devel@nongnu.org; Mon, 14 May 2012 11:44:36 -0400 From: Kevin Wolf Date: Mon, 14 May 2012 17:44:16 +0200 Message-Id: <1337010257-9324-3-git-send-email-kwolf@redhat.com> In-Reply-To: <1337010257-9324-1-git-send-email-kwolf@redhat.com> References: <1337010257-9324-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH 2/3] qcow2: Don't ignore failure to clear autoclear flags List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: anthony@codemonkey.ws Cc: kwolf@redhat.com, qemu-devel@nongnu.org Signed-off-by: Kevin Wolf --- block/qcow2.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 3bae2d8..655799c 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -300,7 +300,10 @@ static int qcow2_open(BlockDriverState *bs, int flags) if (!bs->read_only && s->autoclear_features != 0) { s->autoclear_features = 0; - qcow2_update_header(bs); + ret = qcow2_update_header(bs); + if (ret < 0) { + goto fail; + } } /* Check support for various header values */ -- 1.7.6.5