From: Fabien Chouteau <chouteau@adacore.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, agraf@suse.de
Subject: [Qemu-devel] [PATCH] Avoid segfault in cpu_dump_state
Date: Tue, 15 May 2012 11:39:09 +0200 [thread overview]
Message-ID: <1337074749-24189-1-git-send-email-chouteau@adacore.com> (raw)
In-Reply-To: <CAFEAcA-zROsGTWWDG94KhhJ_HeJxNxzzmCKGJg7HhpKApZ+i2A@mail.gmail.com>
Do not call cpu_dump_state if logfile is NULL.
Signed-off-by: Fabien Chouteau <chouteau@adacore.com>
---
qemu-log.h | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/qemu-log.h b/qemu-log.h
index fccfb110..2cd5ffa 100644
--- a/qemu-log.h
+++ b/qemu-log.h
@@ -51,7 +51,12 @@ extern int loglevel;
/* Special cases: */
/* cpu_dump_state() logging functions: */
-#define log_cpu_state(env, f) cpu_dump_state((env), logfile, fprintf, (f));
+#define log_cpu_state(env, f) \
+do { \
+ if (logfile != NULL) { \
+ cpu_dump_state((env), logfile, fprintf, (f)); \
+ } \
+ } while (0)
#define log_cpu_state_mask(b, env, f) do { \
if (loglevel & (b)) log_cpu_state((env), (f)); \
} while (0)
--
1.7.9.5
next prev parent reply other threads:[~2012-05-15 9:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-14 14:46 [Qemu-devel] [PATCH] PowerPC: Avoid segfault in cpu_dump_state Fabien Chouteau
2012-05-14 15:39 ` Peter Maydell
2012-05-15 9:39 ` Fabien Chouteau [this message]
2012-05-15 13:31 ` [Qemu-devel] [PATCH] " Andreas Färber
2012-05-15 16:08 ` Fabien Chouteau
2012-05-15 16:20 ` Peter Maydell
2012-05-15 16:45 ` Fabien Chouteau
2012-05-15 18:04 ` Peter Maydell
2012-05-16 3:50 ` Andreas Färber
2012-05-16 8:29 ` Fabien Chouteau
2012-05-16 13:39 ` Fabien Chouteau
2012-05-23 15:43 ` Fabien Chouteau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337074749-24189-1-git-send-email-chouteau@adacore.com \
--to=chouteau@adacore.com \
--cc=agraf@suse.de \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).