From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50631) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SUHRh-0004Ig-ML for qemu-devel@nongnu.org; Tue, 15 May 2012 09:05:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SUHRc-0006I8-TY for qemu-devel@nongnu.org; Tue, 15 May 2012 09:05:45 -0400 Received: from mx.meyering.net ([88.168.87.75]:59199 helo=hx.meyering.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SUHRc-0006Hs-Hf for qemu-devel@nongnu.org; Tue, 15 May 2012 09:05:40 -0400 From: jim@meyering.net Date: Tue, 15 May 2012 15:04:38 +0200 Message-Id: <1337087078-24056-4-git-send-email-jim@meyering.net> In-Reply-To: <1337087078-24056-1-git-send-email-jim@meyering.net> References: <1337087078-24056-1-git-send-email-jim@meyering.net> Subject: [Qemu-devel] [PATCH 3/3] sparc: use g_strdup in place of unchecked strdup List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Jim Meyering , Blue Swirl From: Jim Meyering This avoids a NULL-deref upon strdup failure. Also update matching free to g_free. Signed-off-by: Jim Meyering --- target-sparc/cpu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target-sparc/cpu.c b/target-sparc/cpu.c index 7ac6bdb..1e31318 100644 --- a/target-sparc/cpu.c +++ b/target-sparc/cpu.c @@ -648,7 +648,7 @@ static int cpu_sparc_find_by_name(sparc_def_t *cpu_def, const char *cpu_model) { unsigned int i; const sparc_def_t *def = NULL; - char *s = strdup(cpu_model); + char *s = g_strdup(cpu_model); char *featurestr, *name = strtok(s, ","); uint32_t plus_features = 0; uint32_t minus_features = 0; @@ -740,7 +740,7 @@ static int cpu_sparc_find_by_name(sparc_def_t *cpu_def, const char *cpu_model) #ifdef DEBUG_FEATURES print_features(stderr, fprintf, cpu_def->features, NULL); #endif - free(s); + g_free(s); return 0; error: -- 1.7.10.2.484.gcd07cc5