From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37619) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SUJ4K-0000q7-J8 for qemu-devel@nongnu.org; Tue, 15 May 2012 10:49:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SUJ4C-0002yV-Hl for qemu-devel@nongnu.org; Tue, 15 May 2012 10:49:44 -0400 Received: from mail-qa0-f52.google.com ([209.85.216.52]:47343) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SUJ4C-0002yE-Ao for qemu-devel@nongnu.org; Tue, 15 May 2012 10:49:36 -0400 Received: by qabj34 with SMTP id j34so5035720qab.11 for ; Tue, 15 May 2012 07:49:34 -0700 (PDT) Sender: fluxion From: Michael Roth Date: Tue, 15 May 2012 09:48:51 -0500 Message-Id: <1337093339-10786-6-git-send-email-mdroth@linux.vnet.ibm.com> In-Reply-To: <1337093339-10786-1-git-send-email-mdroth@linux.vnet.ibm.com> References: <1337093339-10786-1-git-send-email-mdroth@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH 05/13] qemu-ga: guest-suspend-ram: don't emit a success response List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: mprivozn@redhat.com, aliguori@us.ibm.com, eblake@redhat.com, jcody@redhat.com, lcapitulino@redhat.com From: Luiz Capitulino Today, qemu-ga may not be able to emit a success response when guest-suspend-ram completes. This happens because the VM may suspend before qemu-ga is able to emit a response. This semantic is a bit confusing, as it's not clear for clients if they should wait for a response or how they should check for success. This commit solves that problem by changing guest-suspend-ram to never emit a success response and suggests in the documentation what clients should do to check for success. Signed-off-by: Luiz Capitulino Signed-off-by: Michael Roth --- qapi-schema-guest.json | 16 ++++++++++------ 1 files changed, 10 insertions(+), 6 deletions(-) diff --git a/qapi-schema-guest.json b/qapi-schema-guest.json index 88b165c..50e2815 100644 --- a/qapi-schema-guest.json +++ b/qapi-schema-guest.json @@ -395,17 +395,21 @@ # command. Thus, it's *required* to query QEMU for the presence of the # 'system_wakeup' command before issuing guest-suspend-ram. # -# Returns: nothing on success +# This command does NOT return a response on success. There are two options +# to check for success: +# 1. Wait for the SUSPEND QMP event from QEMU +# 2. Issue the query-status QMP command to confirm the VM status is +# "suspended" +# +# The following errors may be returned: # If suspend to ram is not supported, Unsupported # -# Notes: o This is an asynchronous request. There's no guarantee a response -# will be sent -# o It's strongly recommended to issue the guest-sync command before -# sending commands when the guest resumes +# Notes: It's strongly recommended to issue the guest-sync command before +# sending commands when the guest resumes # # Since: 1.1 ## -{ 'command': 'guest-suspend-ram' } +{ 'command': 'guest-suspend-ram', 'success-response': 'no' } ## # @guest-suspend-hybrid -- 1.7.4.1