From: Anthony PERARD <anthony.perard@citrix.com>
To: QEMU-devel <qemu-devel@nongnu.org>
Cc: Anthony PERARD <anthony.perard@citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Anthony Liguori <anthony@codemonkey.ws>,
Xen Devel <xen-devel@lists.xen.org>
Subject: [Qemu-devel] [PATCH 4/4] xen: Fix PV-on-HVM
Date: Tue, 15 May 2012 16:26:39 +0100 [thread overview]
Message-ID: <1337095599-28836-5-git-send-email-anthony.perard@citrix.com> (raw)
In-Reply-To: <1337095599-28836-1-git-send-email-anthony.perard@citrix.com>
In the context of PV-on-HVM under Xen, the emulated nics are supposed to be
unplug before the guest drivers are initialized. This mean that there must be
unplug without the consent of the guest.
Without this patch, the guest end up with two nics with the same MAC, the
emulated nic and the PV nic.
Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
hw/xen_platform.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/xen_platform.c b/hw/xen_platform.c
index a9c52a6..2e47129 100644
--- a/hw/xen_platform.c
+++ b/hw/xen_platform.c
@@ -87,7 +87,7 @@ static void unplug_nic(PCIBus *b, PCIDevice *d)
{
if (pci_get_word(d->config + PCI_CLASS_DEVICE) ==
PCI_CLASS_NETWORK_ETHERNET) {
- qdev_unplug(&(d->qdev), NULL);
+ qdev_force_unplug(&(d->qdev), NULL);
}
}
--
Anthony PERARD
next prev parent reply other threads:[~2012-05-15 15:31 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-15 15:26 [Qemu-devel] [PATCH 1.1 0/4] Xen: Fix PV-on-HVM Anthony PERARD
2012-05-15 15:26 ` [Qemu-devel] [PATCH 1/4] Introduce a new hotplug state: Force eject Anthony PERARD
2012-05-15 18:19 ` Stefano Stabellini
2012-05-15 18:25 ` Anthony PERARD
2012-05-15 20:52 ` Michael S. Tsirkin
2012-05-16 10:32 ` Stefano Stabellini
2012-05-16 11:15 ` Anthony PERARD
2012-05-16 11:23 ` Paolo Bonzini
2012-05-16 11:37 ` Anthony PERARD
2012-05-16 13:20 ` Michael S. Tsirkin
2012-05-16 15:52 ` Paolo Bonzini
2012-05-16 16:25 ` Michael S. Tsirkin
2012-05-16 16:02 ` Anthony Liguori
2012-05-16 16:24 ` Michael S. Tsirkin
2012-05-15 15:26 ` [Qemu-devel] [PATCH 2/4] qdev: Introduce qdev_force_unplug Anthony PERARD
2012-05-15 18:15 ` Stefano Stabellini
2012-05-15 18:22 ` Anthony PERARD
2012-05-15 15:26 ` [Qemu-devel] [PATCH 3/4] pci: Add force_unplug callback Anthony PERARD
2012-05-15 15:26 ` Anthony PERARD [this message]
2012-05-15 21:00 ` [Qemu-devel] [PATCH 4/4] xen: Fix PV-on-HVM Michael S. Tsirkin
2012-05-16 8:06 ` Paolo Bonzini
2012-05-16 8:13 ` Michael S. Tsirkin
2012-05-16 8:42 ` Paolo Bonzini
2012-05-16 10:19 ` Stefano Stabellini
2012-05-16 10:30 ` Michael S. Tsirkin
2012-05-16 10:37 ` Stefano Stabellini
2012-05-16 13:24 ` Michael S. Tsirkin
2012-05-15 16:26 ` [Qemu-devel] [PATCH 1.1 0/4] Xen: " Anthony Liguori
2012-05-15 16:42 ` Stefano Stabellini
2012-05-15 18:20 ` Stefano Stabellini
2012-05-15 21:06 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337095599-28836-5-git-send-email-anthony.perard@citrix.com \
--to=anthony.perard@citrix.com \
--cc=anthony@codemonkey.ws \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).