qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: qemu-devel@nongnu.org
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [Qemu-devel] [PATCH 01/12] Better support for dma_addr_t variables
Date: Wed, 16 May 2012 14:27:14 +1000	[thread overview]
Message-ID: <1337142445-26548-2-git-send-email-benh@kernel.crashing.org> (raw)
In-Reply-To: <1337142445-26548-1-git-send-email-benh@kernel.crashing.org>

From: David Gibson <david@gibson.dropbear.id.au>

A while back, we introduced the dma_addr_t type, which is supposed to
be used for bus visible memory addresses.  At present, this is an
alias for target_phys_addr_t, but this will change when we eventually
add support for guest visible IOMMUs.

There are some instances of target_phys_addr_t in the code now which
should really be dma_addr_t, but can't be trivially converted due to
missing features which this patch corrects.

 * We add DMA_ADDR_BITS analagous to TARGET_PHYS_ADDR_BITS.  This is
   important where we need to make a compile-time (#if) based on the
   size of dma_addr_t.

 * We add a new helper macro to create device properties which take a
   dma_addr_t, currently an alias to DEFINE_PROP_TADDR().

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---
 dma.h         |    1 +
 hw/qdev-dma.h |   12 ++++++++++++
 2 files changed, 13 insertions(+)
 create mode 100644 hw/qdev-dma.h

diff --git a/dma.h b/dma.h
index 8c1ec8f..fe08b72 100644
--- a/dma.h
+++ b/dma.h
@@ -31,6 +31,7 @@ struct QEMUSGList {
 #if defined(TARGET_PHYS_ADDR_BITS)
 typedef target_phys_addr_t dma_addr_t;
 
+#define DMA_ADDR_BITS TARGET_PHYS_ADDR_BITS
 #define DMA_ADDR_FMT TARGET_FMT_plx
 
 struct ScatterGatherEntry {
diff --git a/hw/qdev-dma.h b/hw/qdev-dma.h
new file mode 100644
index 0000000..f0ff558
--- /dev/null
+++ b/hw/qdev-dma.h
@@ -0,0 +1,12 @@
+/*
+ * Support for dma_addr_t typed properties
+ *
+ * Copyright (C) 2012 David Gibson, IBM Corporation.
+ *
+ * This work is licensed under the terms of the GNU GPL, version 2 or later.
+ * See the COPYING file in the top-level directory.
+ */
+#include "qdev-addr.h"
+
+#define DEFINE_PROP_DMAADDR(_n, _s, _f, _d)                               \
+    DEFINE_PROP_TADDR(_n, _s, _f, _d)
-- 
1.7.9.5

  reply	other threads:[~2012-05-16  4:28 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-16  4:27 [Qemu-devel] [PATCH 00/12] IOMMU Infrastructure Benjamin Herrenschmidt
2012-05-16  4:27 ` Benjamin Herrenschmidt [this message]
2012-05-16  4:27 ` [Qemu-devel] [PATCH 02/12] Implement cpu_physical_memory_set() Benjamin Herrenschmidt
2012-05-16  4:27 ` [Qemu-devel] [PATCH 03/12] iommu: Add universal DMA helper functions Benjamin Herrenschmidt
2012-05-16  4:27 ` [Qemu-devel] [PATCH 04/12] usb-ohci: Use " Benjamin Herrenschmidt
2012-05-16  4:27 ` [Qemu-devel] [PATCH 05/12] iommu: Make sglists and dma_bdrv helpers use new universal DMA helpers Benjamin Herrenschmidt
2012-05-16  4:27 ` [Qemu-devel] [PATCH 06/12] ide/ahci: Use universal DMA helper functions Benjamin Herrenschmidt
2012-05-16  4:27 ` [Qemu-devel] [PATCH 07/12] usb: Convert usb_packet_{map, unmap} to universal DMA helpers Benjamin Herrenschmidt
2012-05-16  4:27 ` [Qemu-devel] [PATCH 08/12] iommu: Introduce IOMMU emulation infrastructure Benjamin Herrenschmidt
2012-05-16  4:27 ` [Qemu-devel] [PATCH 09/12] iommu: Add facility to cancel in-use dma memory maps Benjamin Herrenschmidt
2012-05-16  4:27 ` [Qemu-devel] [PATCH 10/12] pseries: Convert sPAPR TCEs to use generic IOMMU infrastructure Benjamin Herrenschmidt
2012-05-16  4:27 ` [Qemu-devel] [PATCH 11/12] iommu: Allow PCI to use " Benjamin Herrenschmidt
2012-05-16  4:27 ` [Qemu-devel] [PATCH 12/12] pseries: Implement IOMMU and DMA for PAPR PCI devices Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1337142445-26548-2-git-send-email-benh@kernel.crashing.org \
    --to=benh@kernel.crashing.org \
    --cc=david@gibson.dropbear.id.au \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).