From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39992) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SVO1C-0003jy-L3 for qemu-devel@nongnu.org; Fri, 18 May 2012 10:19:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SVO19-0005xE-6b for qemu-devel@nongnu.org; Fri, 18 May 2012 10:18:58 -0400 Received: from mail-pz0-f45.google.com ([209.85.210.45]:34862) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SVO18-0005va-U9 for qemu-devel@nongnu.org; Fri, 18 May 2012 10:18:55 -0400 Received: by mail-pz0-f45.google.com with SMTP id v2so4854728dad.4 for ; Fri, 18 May 2012 07:18:54 -0700 (PDT) Sender: Paolo Bonzini From: Paolo Bonzini Date: Fri, 18 May 2012 16:18:28 +0200 Message-Id: <1337350712-29183-4-git-send-email-pbonzini@redhat.com> In-Reply-To: <1337350712-29183-1-git-send-email-pbonzini@redhat.com> References: <1337350712-29183-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [RFC PATCH 3/7] block: do not pass BDRV_O_CACHE_WB to the protocol List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, stefanha@linux.vnet.ibm.com, anthony@codemonkey.ws Formats are entirely in charge of flushes for metadata writes. For guest-initiated writes, a writethrough cache is faked in the block layer. Signed-off-by: Paolo Bonzini --- block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block.c b/block.c index 3db7150..b3d0054 100644 --- a/block.c +++ b/block.c @@ -661,7 +661,7 @@ static int bdrv_open_common(BlockDriverState *bs, const char *filename, if (drv->bdrv_file_open) { ret = drv->bdrv_file_open(bs, filename, open_flags); } else { - ret = bdrv_file_open(&bs->file, filename, open_flags); + ret = bdrv_file_open(&bs->file, filename, open_flags & ~BDRV_O_CACHE_WB); if (ret >= 0) { ret = drv->bdrv_open(bs, open_flags); } -- 1.7.10.1