qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, stefanha@linux.vnet.ibm.com, anthony@codemonkey.ws
Subject: [Qemu-devel] [RFC PATCH 4/7] block: copy enable_write_cache in bdrv_append
Date: Fri, 18 May 2012 16:18:29 +0200	[thread overview]
Message-ID: <1337350712-29183-5-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1337350712-29183-1-git-send-email-pbonzini@redhat.com>

Because the guest will be able to flip enable_write_cache, the actual
state may not match what is used to open the new snapshot.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 block.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/block.c b/block.c
index b3d0054..e89b35a 100644
--- a/block.c
+++ b/block.c
@@ -989,6 +989,8 @@ void bdrv_append(BlockDriverState *bs_new, BlockDriverState *bs_top)
     tmp.buffer_alignment  = bs_top->buffer_alignment;
     tmp.copy_on_read      = bs_top->copy_on_read;
 
+    tmp.enable_write_cache = bs_top->enable_write_cache;
+
     /* i/o timing parameters */
     tmp.slice_time        = bs_top->slice_time;
     tmp.slice_start       = bs_top->slice_start;
-- 
1.7.10.1

  parent reply	other threads:[~2012-05-18 14:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-18 14:18 [Qemu-devel] [RFC PATCH 0/7] Manual writethrough cache and cache mode toggle Paolo Bonzini
2012-05-18 14:18 ` [Qemu-devel] [RFC PATCH 1/7] block: flush in writethrough mode after writes Paolo Bonzini
2012-05-18 14:18 ` [Qemu-devel] [RFC PATCH 2/7] savevm: flush after saving vm state Paolo Bonzini
2012-05-18 14:18 ` [Qemu-devel] [RFC PATCH 3/7] block: do not pass BDRV_O_CACHE_WB to the protocol Paolo Bonzini
2012-05-23 12:06   ` Stefan Hajnoczi
2012-05-23 12:11     ` Paolo Bonzini
2012-05-18 14:18 ` Paolo Bonzini [this message]
2012-05-18 14:18 ` [Qemu-devel] [RFC PATCH 5/7] block: add bdrv_set_enable_write_cache Paolo Bonzini
2012-05-18 14:18 ` [Qemu-devel] [RFC PATCH 6/7] ide: support enable/disable write cache Paolo Bonzini
2012-05-18 14:18 ` [Qemu-devel] [RFC PATCH 7/7] block: do not handle writethrough in qcow2 caches Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1337350712-29183-5-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).