qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jim Meyering <jim@meyering.net>
To: qemu-devel@nongnu.org
Cc: Jim Meyering <meyering@redhat.com>,
	Stefan Weil <weil@mail.berlios.de>,
	Anthony Liguori <aliguori@us.ibm.com>
Subject: [Qemu-devel] [PATCH 7/9] mips-dis: declare four globals to be "static"
Date: Mon, 21 May 2012 21:56:22 +0200	[thread overview]
Message-ID: <1337630184-30581-5-git-send-email-jim@meyering.net> (raw)
In-Reply-To: <1337630184-30581-1-git-send-email-jim@meyering.net>

From: Jim Meyering <meyering@redhat.com>


Signed-off-by: Jim Meyering <meyering@redhat.com>
---
 mips-dis.c | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

diff --git a/mips-dis.c b/mips-dis.c
index e3a6e0b..f6109a1 100644
--- a/mips-dis.c
+++ b/mips-dis.c
@@ -888,10 +888,9 @@ enum
    Many instructions are short hand for other instructions (i.e., The
    jal <register> instruction is short for jalr <register>).  */

-extern const struct mips_opcode mips_builtin_opcodes[];
-extern const int bfd_mips_num_builtin_opcodes;
-extern struct mips_opcode *mips_opcodes;
-extern int bfd_mips_num_opcodes;
+static const struct mips_opcode mips_builtin_opcodes[];
+static const int bfd_mips_num_builtin_opcodes;
+static int bfd_mips_num_opcodes;
 #define NUMOPCODES bfd_mips_num_opcodes

 \f

@@ -1203,7 +1202,7 @@ extern const int bfd_mips16_num_opcodes;
    Many instructions are short hand for other instructions (i.e., The
    jal <register> instruction is short for jalr <register>).  */

-const struct mips_opcode mips_builtin_opcodes[] =
+static const struct mips_opcode mips_builtin_opcodes[] =
 {
 /* These instructions appear first so that the disassembler will find
    them first.  The assemblers uses a hash table based on the
@@ -2756,13 +2755,13 @@ const struct mips_opcode mips_builtin_opcodes[] =

 #define MIPS_NUM_OPCODES \
 	((sizeof mips_builtin_opcodes) / (sizeof (mips_builtin_opcodes[0])))
-const int bfd_mips_num_builtin_opcodes = MIPS_NUM_OPCODES;
+static const int bfd_mips_num_builtin_opcodes = MIPS_NUM_OPCODES;

 /* const removed from the following to allow for dynamic extensions to the
  * built-in instruction set. */
-struct mips_opcode *mips_opcodes =
+static struct mips_opcode *mips_opcodes =
   (struct mips_opcode *) mips_builtin_opcodes;
-int bfd_mips_num_opcodes = MIPS_NUM_OPCODES;
+static int bfd_mips_num_opcodes = MIPS_NUM_OPCODES;
 #undef MIPS_NUM_OPCODES

 /* Mips instructions are at maximum this many bytes long.  */
-- 
1.7.10.2.552.gaa3bb87

  parent reply	other threads:[~2012-05-21 19:56 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-21 19:51 [Qemu-devel] [PATCH 0/9] convert many more globals to "static" Jim Meyering
2012-05-21 19:51 ` [Qemu-devel] [PATCH 1/9] ccid: declare DEFAULT_ATR table to be "static const" Jim Meyering
2012-05-21 19:51 ` Jim Meyering
2012-05-21 19:51 ` [Qemu-devel] [PATCH 2/9] tcg: declare __jit_debug_descriptor to be static Jim Meyering
2012-05-21 19:51 ` Jim Meyering
2012-05-21 19:58   ` Peter Maydell
2012-05-21 20:10     ` Jim Meyering
2012-05-21 20:31       ` Peter Maydell
2012-05-22 10:26         ` Jim Meyering
2012-05-21 19:51 ` [Qemu-devel] [PATCH 3/9] alpha-dis: remove unused global; declare others " Jim Meyering
2012-05-21 19:56 ` Jim Meyering
2012-05-21 19:56   ` [Qemu-devel] [PATCH 4/9] linux-user: arg_table need not have global scope Jim Meyering
2012-05-21 19:56   ` [Qemu-devel] [PATCH 5/9] ccid: make backend_enum_table "static const" and adjust users Jim Meyering
2012-05-21 19:56   ` [Qemu-devel] [PATCH 6/9] sheepdog: declare bdrv_sheepdog to be static Jim Meyering
2012-05-21 19:56   ` Jim Meyering [this message]
2012-05-21 19:56   ` [Qemu-devel] [PATCH 8/9] bonito: declare bonito_state " Jim Meyering
2012-05-21 19:56   ` [Qemu-devel] [PATCH 9/9] convert many more globals to static Jim Meyering
2012-08-17 13:37 ` [Qemu-devel] [PATCH 0/9] convert many more globals to "static" Jim Meyering
2012-08-17 13:45   ` Stefan Weil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1337630184-30581-5-git-send-email-jim@meyering.net \
    --to=jim@meyering.net \
    --cc=aliguori@us.ibm.com \
    --cc=meyering@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=weil@mail.berlios.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).