From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45790) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SWrmG-0007MJ-HA for qemu-devel@nongnu.org; Tue, 22 May 2012 12:17:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SWrmD-0001ah-NH for qemu-devel@nongnu.org; Tue, 22 May 2012 12:17:40 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:45575) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SWrmD-0001YK-FP for qemu-devel@nongnu.org; Tue, 22 May 2012 12:17:37 -0400 Received: by mail-pb0-f45.google.com with SMTP id ro12so10359091pbb.4 for ; Tue, 22 May 2012 09:17:36 -0700 (PDT) Sender: Paolo Bonzini From: Paolo Bonzini Date: Tue, 22 May 2012 18:17:13 +0200 Message-Id: <1337703438-9764-3-git-send-email-pbonzini@redhat.com> In-Reply-To: <1337703438-9764-1-git-send-email-pbonzini@redhat.com> References: <1337703438-9764-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH 1.2 2/7] savevm: flush after saving vm state List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com Writing vm state uses bdrv_pwrite, so it will automatically get flushes in writethrough mode. But doing a flush at the end in writeback mode is probably a good idea anyway. Signed-off-by: Paolo Bonzini --- savevm.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/savevm.c b/savevm.c index 2d18bab..2b6833d 100644 --- a/savevm.c +++ b/savevm.c @@ -400,7 +400,7 @@ static int block_get_buffer(void *opaque, uint8_t *buf, int64_t pos, int size) static int bdrv_fclose(void *opaque) { - return 0; + return bdrv_flush(opaque); } static QEMUFile *qemu_fopen_bdrv(BlockDriverState *bs, int is_writable) -- 1.7.1