qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Liu ping fan <kernelfans@gmail.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	qemu-devel@nongnu.org, Ingo Molnar <mingo@redhat.com>,
	Avi Kivity <avi@redhat.com>,
	Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [Qemu-devel] [PATCH 1/2] sched: add virt sched domain for the guest
Date: Wed, 23 May 2012 10:48:34 +0200	[thread overview]
Message-ID: <1337762914.9698.65.camel@twins> (raw)
In-Reply-To: <CAFgQCTt+cmUWUB6GvE=Ki5ikC1P7YA_sGrvgUKKJ6c3VuqCsAg@mail.gmail.com>

On Wed, 2012-05-23 at 16:34 +0800, Liu ping fan wrote:
> so we need to migrate some of vcpus from node-B to node-A, or to
> node-C.

This is absolutely broken, you cannot do that.

A guest task might want to be node affine, it looks at the topology sets
a cpu affinity mask and expects to stay on that node.

But then you come along, and flip one of those cpus to another node. The
guest task will now run on another node and get remote memory accesses.

Similarly for the guest kernel, it assumes cpu:node maps are static, it
will use this for all kinds of things, including the allocation of
per-cpu memory to be node affine to that cpu.

If you go migrate cpus across nodes everything comes down.


Please go do something else, I'll do this.

  reply	other threads:[~2012-05-23  8:48 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-23  6:32 [Qemu-devel] [RFC] kvm: export host NUMA info to guest's scheduler Liu Ping Fan
2012-05-23  6:32 ` [Qemu-devel] [PATCH 1/2] sched: add virt sched domain for the guest Liu Ping Fan
2012-05-23  7:54   ` Peter Zijlstra
2012-05-23  8:10     ` Liu ping fan
2012-05-23  8:23       ` Peter Zijlstra
2012-05-23  8:34         ` Liu ping fan
2012-05-23  8:48           ` Peter Zijlstra [this message]
2012-05-23  9:58             ` Liu ping fan
2012-05-23 10:14               ` Peter Zijlstra
2012-05-23 15:23             ` Dave Hansen
2012-05-23 15:52               ` Peter Zijlstra
2012-05-23  6:32 ` [Qemu-devel] [PATCH 2/2] sched: add virt domain device's driver Liu Ping Fan
2012-05-23  6:32 ` [Qemu-devel] [PATCH] kvm: collect vcpus' numa info for guest's scheduler Liu Ping Fan
2012-05-23  6:32 ` [Qemu-devel] [PATCH] Qemu: add virt sched domain device Liu Ping Fan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1337762914.9698.65.camel@twins \
    --to=peterz@infradead.org \
    --cc=anthony@codemonkey.ws \
    --cc=avi@redhat.com \
    --cc=kernelfans@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).