From: Stefan Weil <sw@weilnetz.de>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Stefan Weil <sw@weilnetz.de>, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 1.1] vga: Initialise VRAM with 0
Date: Wed, 23 May 2012 22:54:14 +0200 [thread overview]
Message-ID: <1337806454-4084-1-git-send-email-sw@weilnetz.de> (raw)
The VNC code reads this memory before it is written by BIOS or
other code. Avoid random values by setting the VRAM to 0.
This bug was reported by Valgrind.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
hw/vga.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/vga.c b/hw/vga.c
index 1469680..80b8ec3 100644
--- a/hw/vga.c
+++ b/hw/vga.c
@@ -2283,6 +2283,7 @@ void vga_common_init(VGACommonState *s, int vga_ram_size)
s->update_retrace_info = vga_precise_update_retrace_info;
break;
}
+ memset(s->vram_ptr, 0, s->vram_size);
vga_dirty_log_start(s);
}
--
1.7.10
next reply other threads:[~2012-05-23 20:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-23 20:54 Stefan Weil [this message]
2012-05-24 11:18 ` [Qemu-devel] [PATCH 1.1] vga: Initialise VRAM with 0 Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337806454-4084-1-git-send-email-sw@weilnetz.de \
--to=sw@weilnetz.de \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).