From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56385) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXIZd-0000qH-3o for qemu-devel@nongnu.org; Wed, 23 May 2012 16:54:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SXIZb-0005LL-84 for qemu-devel@nongnu.org; Wed, 23 May 2012 16:54:24 -0400 Received: from v220110690675601.yourvserver.net ([78.47.199.172]:48810) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXIZb-0005KD-1s for qemu-devel@nongnu.org; Wed, 23 May 2012 16:54:23 -0400 From: Stefan Weil Date: Wed, 23 May 2012 22:54:14 +0200 Message-Id: <1337806454-4084-1-git-send-email-sw@weilnetz.de> Subject: [Qemu-devel] [PATCH 1.1] vga: Initialise VRAM with 0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Stefan Weil , qemu-devel@nongnu.org The VNC code reads this memory before it is written by BIOS or other code. Avoid random values by setting the VRAM to 0. This bug was reported by Valgrind. Signed-off-by: Stefan Weil --- hw/vga.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/vga.c b/hw/vga.c index 1469680..80b8ec3 100644 --- a/hw/vga.c +++ b/hw/vga.c @@ -2283,6 +2283,7 @@ void vga_common_init(VGACommonState *s, int vga_ram_size) s->update_retrace_info = vga_precise_update_retrace_info; break; } + memset(s->vram_ptr, 0, s->vram_size); vga_dirty_log_start(s); } -- 1.7.10