From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57918) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXUV3-0002Zd-GK for qemu-devel@nongnu.org; Thu, 24 May 2012 05:38:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SXUUv-0007r1-UC for qemu-devel@nongnu.org; Thu, 24 May 2012 05:38:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:5391) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXUUv-0007qU-N1 for qemu-devel@nongnu.org; Thu, 24 May 2012 05:38:21 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q4O9cKin031654 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 24 May 2012 05:38:20 -0400 From: Alon Levy Date: Thu, 24 May 2012 12:38:14 +0300 Message-Id: <1337852294-12224-4-git-send-email-alevy@redhat.com> In-Reply-To: <1337852294-12224-1-git-send-email-alevy@redhat.com> References: <4FBDF65F.8070609@redhat.com> <1337852294-12224-1-git-send-email-alevy@redhat.com> Subject: [Qemu-devel] [PATCH 4/4] qxl: stop dirty loging when not in vga mode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, kraxel@redhat.com Tested with linux guest. Not sure how to check actual performance affect of this. Checked with the previously send traceevent that the kvm ioctl to start/stop dirty logging is being called. (KVM_SET_USER_MEMORY_REGION). Signed-off-by: Alon Levy --- hw/qxl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/qxl.c b/hw/qxl.c index e28c482..05ff176 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -932,6 +932,7 @@ static void qxl_enter_vga_mode(PCIQXLDevice *d) qemu_spice_create_host_primary(&d->ssd); d->mode = QXL_MODE_VGA; memset(&d->ssd.dirty, 0, sizeof(d->ssd.dirty)); + vga_dirty_log_start(&d->vga); } static void qxl_exit_vga_mode(PCIQXLDevice *d) @@ -940,6 +941,7 @@ static void qxl_exit_vga_mode(PCIQXLDevice *d) return; } trace_qxl_exit_vga_mode(d->id); + vga_dirty_log_stop(&d->vga); qxl_destroy_primary(d, QXL_SYNC); } -- 1.7.10.1