qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alon Levy <alevy@redhat.com>
To: qemu-devel@nongnu.org, kraxel@redhat.com
Subject: [Qemu-devel] [PATCH 1/2] qxl: stop dirty loging when not in vga mode
Date: Thu, 24 May 2012 19:18:53 +0300	[thread overview]
Message-ID: <1337876334-32602-1-git-send-email-alevy@redhat.com> (raw)
In-Reply-To: <4FBE3080.9040201@redhat.com>

Tested with linux guest. Not sure how to check actual performance affect
of this. Checked with the previously send traceevent that the kvm ioctl
to start/stop dirty logging is being called.
(KVM_SET_USER_MEMORY_REGION).

Signed-off-by: Alon Levy <alevy@redhat.com>
---
These are the two patches to queue instead of the previously squashed patch.

 hw/qxl.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/hw/qxl.c b/hw/qxl.c
index 8777ba9..5a7be60 100644
--- a/hw/qxl.c
+++ b/hw/qxl.c
@@ -932,6 +932,7 @@ static void qxl_enter_vga_mode(PCIQXLDevice *d)
     qemu_spice_create_host_primary(&d->ssd);
     d->mode = QXL_MODE_VGA;
     memset(&d->ssd.dirty, 0, sizeof(d->ssd.dirty));
+    vga_dirty_log_start(&d->vga);
 }
 
 static void qxl_exit_vga_mode(PCIQXLDevice *d)
@@ -940,6 +941,7 @@ static void qxl_exit_vga_mode(PCIQXLDevice *d)
         return;
     }
     trace_qxl_exit_vga_mode(d->id);
+    vga_dirty_log_stop(&d->vga);
     qxl_destroy_primary(d, QXL_SYNC);
 }
 
-- 
1.7.10.1

  parent reply	other threads:[~2012-05-24 16:19 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-22 15:29 [Qemu-devel] [PATCHv2 1/3] ui/spice-display.c: add missing initialization for valgrind Alon Levy
2012-05-22 15:29 ` [Qemu-devel] [PATCHv2 2/3] hw/qxl: s/qxl_guest_bug/qxl_set_guest_bug/ Alon Levy
2012-05-22 15:30 ` [Qemu-devel] [PATCHv2 3/3] hmp/qxl: info spice: add qxl info Alon Levy
2012-05-23 18:59 ` [Qemu-devel] [PATCHv2 1/3] ui/spice-display.c: add missing initialization for valgrind Gerd Hoffmann
2012-05-24  6:43   ` Alon Levy
2012-05-24  6:51     ` Gerd Hoffmann
2012-05-24  8:50       ` Gerd Hoffmann
2012-05-24  9:38         ` [Qemu-devel] [PATCH 1/4] " Alon Levy
2012-05-24  9:38           ` [Qemu-devel] [PATCH 2/4] hw/qxl: s/qxl_guest_bug/qxl_set_guest_bug/ Alon Levy
2012-05-24  9:38           ` [Qemu-devel] [PATCH 3/4] hmp/qxl: info spice: add qxl info Alon Levy
2012-05-24 12:58             ` Gerd Hoffmann
2012-05-24 16:15               ` Alon Levy
2012-05-24 16:18               ` Alon Levy [this message]
2012-05-24 16:18                 ` [Qemu-devel] [PATCH 2/2] hw/qxl: ignore guest from guestbug until reset Alon Levy
2012-05-24  9:38           ` [Qemu-devel] [PATCH 4/4] qxl: stop dirty loging when not in vga mode Alon Levy
2012-05-24  9:47           ` [Qemu-devel] [PATCH 1/4] ui/spice-display.c: add missing initialization for valgrind Alon Levy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1337876334-32602-1-git-send-email-alevy@redhat.com \
    --to=alevy@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).