From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49889) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXqlB-00057O-Mz for qemu-devel@nongnu.org; Fri, 25 May 2012 05:24:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SXql4-0004oO-DD for qemu-devel@nongnu.org; Fri, 25 May 2012 05:24:37 -0400 Received: from gate.crashing.org ([63.228.1.57]:39158) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXql4-0004oA-3S for qemu-devel@nongnu.org; Fri, 25 May 2012 05:24:30 -0400 Message-ID: <1337937864.16119.20.camel@pasglop> From: Benjamin Herrenschmidt Date: Fri, 25 May 2012 19:24:24 +1000 In-Reply-To: References: <1337585042.2779.4.camel@pasglop> <4FBA0F23.5040601@redhat.com> <1337594641.2779.59.camel@pasglop> <4FBA13DF.7040009@redhat.com> <1337918007.16119.13.camel@pasglop> <678ADF6E-BA35-48A4-865A-C45D1353022B@suse.de> <1337934969.16119.18.camel@pasglop> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH v2] spapr: Add "memop" hypercall List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: "qemu-devel@nongnu.org" , kvm-ppc , "kvm@vger.kernel.org" , Avi Kivity On Fri, 2012-05-25 at 10:54 +0200, Alexander Graf wrote: > >> case x: > >> foo(); > >> break(); > >> > >>> break; > >>> + case 1: tmp = lduw_phys(src); break; > >>> + case 2: tmp = ldl_phys(src); break; > >>> + case 3: tmp = ldq_phys(src); break; > >>> + default: > >>> + return H_PARAMETER; > > > > Checkpatch absolutely complained and I decided to ignore it, seriously, > > you really want to replace a nice & readable piece of code with > > something that takes 3 pages and is generally gross & ugly ? > > > > Some times, you have to ignore check patch and let sanity prevail. > > I'm not all that keen on coding style rules. But check out > arch/powerpc/kvm/emulate.c and tell me that it's a good idea to go > with this "clean" approach. If you want it really clean, put the whole > chunk above into a geberic helper that allows for everyone to say > "read n bytes of data with native endianness into a u64". In that > code, the more verbose coding style checkpatch suggests doesn't hurt > and your function becomes even easier to read :) I find your lack of taste disturbing Luke :-) > Yeah, it's a shame I didn't read through it more thoroughly earlier - at least it didn't take weeks in this round ;). > > No worries though, if you can't make it until Monday, I'll fix it up myself afterwards :). There's no black magic involved here, > so I should be ok to respin myself. Sure. No worries. To test it properly you really need a newer SLOF and the patch to add -vga tho, I'll sort that out when I'm back. Cheers, Ben. > Alex