qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: Anthony Liguori <aliguori@us.ibm.com>, patches@linaro.org
Subject: [Qemu-devel] [PATCH] qemu_find_file: check name as a straight path even if it has no '/'
Date: Fri, 25 May 2012 13:07:01 +0100	[thread overview]
Message-ID: <1337947621-8610-1-git-send-email-peter.maydell@linaro.org> (raw)

Make qemu_find_file() check for the passed in name as a straight
pathname even if it doesn't have any path separator character in it.
This means that "-bios foo", "-dtb foo" etc will find a file 'foo'
in the current directory.
This removes an inconsistency with -kernel and -initrd, which both
accept plain filenames as meaning files in the current directory.
It's also less confusing for the user than an undocumented restriction
that "this option accepts a filename, except for the special case
where the filename you pass happens not to have a '/' in it, in
which case we'll ignore it."

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 vl.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/vl.c b/vl.c
index 23ab3a3..4639526 100644
--- a/vl.c
+++ b/vl.c
@@ -1801,9 +1801,8 @@ char *qemu_find_file(int type, const char *name)
     const char *subdir;
     char *buf;
 
-    /* If name contains path separators then try it as a straight path.  */
-    if ((strchr(name, '/') || strchr(name, '\\'))
-        && access(name, R_OK) == 0) {
+    /* Try the name as a straight path first */
+    if (access(name, R_OK) == 0) {
         return g_strdup(name);
     }
     switch (type) {
-- 
1.7.1

             reply	other threads:[~2012-05-25 12:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-25 12:07 Peter Maydell [this message]
2012-05-25 12:21 ` [Qemu-devel] [PATCH] qemu_find_file: check name as a straight path even if it has no '/' Andreas Färber
2012-05-25 12:23   ` Edgar E. Iglesias
2012-06-19 15:13 ` Peter Maydell
     [not found]   ` <CAFEAcA9KHcJjrK7pzTd7Pexi1Sq46V1DOosoGPS4XxiF2si-yQ@mail.gmail.com>
2012-07-10 14:18     ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1337947621-8610-1-git-send-email-peter.maydell@linaro.org \
    --to=peter.maydell@linaro.org \
    --cc=aliguori@us.ibm.com \
    --cc=patches@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).